[18.0][FIX] mail_composer_cc_bcc: email_cc type - #249
Open
trisdoan wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hello @norlinhenrik , could you take a look please? |
trisdoan
force-pushed
the
fix/18.0-fix-mail_composer_cc_bcc
branch
from
August 17, 2026 09:47
ec81f3f to
e64ee2c
Compare
Contributor
Maybe Please install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
mail_composer_cc_bccoverridesmail.mail._prepare_outgoing_list()and was putting a comma-joined string intoemail_to, where native produces a list.mail_trackingre-joinsemail_towithCOMMASPACE, which mangles a value that is already a string.format_emails()return the list formIn the same commit, in the same function,
email_ccwas changed in the opposite direction — from the list form to the joined-string form:So the commit made
email_toa list andemail_cca string, in adjacent lines of the same dict.Solution
restoring the list form so
email_ccmatchesemail_toon the line directly