Skip to content

[19.0][FIX] mail_activity_team: fix team functionality and related views for mail activities - #200

Open
CRogos wants to merge 1 commit into
OCA:19.0from
c4a8-odoo:copilot/fix-owl-error-lifecycle
Open

[19.0][FIX] mail_activity_team: fix team functionality and related views for mail activities#200
CRogos wants to merge 1 commit into
OCA:19.0from
c4a8-odoo:copilot/fix-owl-error-lifecycle

Conversation

@CRogos

@CRogos CRogos commented May 28, 2026

Copy link
Copy Markdown
Contributor

@muaazsiddiq @MohamedOsman7 we did a bad job on the migration. Could you review again?

When opening a page with activities this error occurs:
image

Further more, the marked fields were not displayed.
image

@OCA-git-bot OCA-git-bot added mod:mail_activity_team Module mail_activity_team series:19.0 labels May 28, 2026

@MohamedOsman7 MohamedOsman7 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested.

@CRogos
CRogos force-pushed the copilot/fix-owl-error-lifecycle branch from 95158b5 to ffaa8b2 Compare May 28, 2026 17:45
@CRogos

CRogos commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Add port forward of #148

@CRogos
CRogos force-pushed the copilot/fix-owl-error-lifecycle branch from c7d286a to 21ce019 Compare May 29, 2026 14:44
@CRogos
CRogos force-pushed the copilot/fix-owl-error-lifecycle branch from 21ce019 to d3380ce Compare July 1, 2026 08:25
@CRogos
CRogos force-pushed the copilot/fix-owl-error-lifecycle branch from d3380ce to 682e486 Compare July 1, 2026 08:54
@CRogos

CRogos commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@StefanRijnhart could you review/merge?

@StefanRijnhart

Copy link
Copy Markdown
Member

Is this a migration fix now or a forward port? There is only one commit.

@CRogos

CRogos commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

There were some bugs in the migration and the one PR was missing... I probably squashed everything.
I agree that two different commits would have been better :(

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create separate PRs for the fix and the backport

@CRogos

CRogos commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

It is not a backport. It is both code which was missed out from the migration. I don't see any benefit to move this into two separate PRs. (I do not have the time, so I won't be able to do that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:mail_activity_team Module mail_activity_team series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants