Skip to content

[MIG] fleet_vehicle_inspection_template: Migration to 19.0 - #223

Open
yvaucher wants to merge 33 commits into
OCA:19.0from
acsone:19.0-mig-fleet_vehicle_inspection_template
Open

[MIG] fleet_vehicle_inspection_template: Migration to 19.0#223
yvaucher wants to merge 33 commits into
OCA:19.0from
acsone:19.0-mig-fleet_vehicle_inspection_template

Conversation

@yvaucher

@yvaucher yvaucher commented May 8, 2026

Copy link
Copy Markdown
Member

No description provided.

@OCA-git-bot OCA-git-bot added series:19.0 mod:fleet_vehicle_inspection_template Module fleet_vehicle_inspection_template labels May 8, 2026
@yvaucher

yvaucher commented May 8, 2026

Copy link
Copy Markdown
Member Author

/ocabot migration fleet_vehicle_inspection_template

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone May 8, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request May 8, 2026
12 tasks
@yvaucher
yvaucher force-pushed the 19.0-mig-fleet_vehicle_inspection_template branch from fc7393e to eb73300 Compare May 31, 2026 10:43

@marcelsavegnago marcelsavegnago left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

self.name = self.inspection_template_id.name
self.note = self.inspection_template_id.note

inspection_lines = [(5, 0, 0)]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inspection_lines = [(5, 0, 0)]
inspection_lines = [Command.clear()]

"sequence"
):
data = self._compute_line_data_for_template_change(line)
inspection_lines.append((0, 0, data))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inspection_lines.append((0, 0, data))
inspection_lines.append(Command.create(data))

Comment on lines +36 to +38
(
0,
0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(
0,
0,
Command.create(

@petrus-v petrus-v left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review migration commit LGTM

@petrus-v
petrus-v force-pushed the 19.0-mig-fleet_vehicle_inspection_template branch from eb73300 to 48a6257 Compare July 31, 2026 15:35
@petrus-v

Copy link
Copy Markdown

Thanks for your review @BhaveshHeliconia I've fixed them ;) !

@AnizR AnizR left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks 🚀

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor

@petrus-v could you please squash the administrative commits? There are quite a few commits that can be squashed.

marcelsavegnago and others added 15 commits August 4, 2026 11:16
[UPD] Update fleet_vehicle_inspection_template.pot
[UPD] Update fleet_vehicle_inspection_template.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_inspection_template/
Currently translated at 100.0% (49 of 49 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_inspection_template/pt_BR/
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_inspection_template/
Currently translated at 100.0% (50 of 50 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_inspection_template/pt_BR/
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_inspection_template/
Currently translated at 96.1% (50 of 52 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_inspection_template/pt_BR/
[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_inspection_template/
mymage and others added 18 commits August 4, 2026 11:19
Currently translated at 100.0% (53 of 53 strings)

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_inspection_template/it/
Currently translated at 100.0% (53 of 53 strings)

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_inspection_template/es/
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_inspection_template/
[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-16.0/fleet-16.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_inspection_template/
Currently translated at 100.0% (49 of 49 strings)

Translation: fleet-16.0/fleet-16.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_inspection_template/it/
Currently translated at 100.0% (49 of 49 strings)

Translation: fleet-16.0/fleet-16.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_inspection_template/pt_BR/
Update fleet_vehicle_inspection_template/models/fleet_vehicle_inspection.py

use the model's sorted method

Co-authored-by: Iván Todorovich <ivan.todorovich@gmail.com>

pre-commit fix
[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-16.0/fleet-16.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_inspection_template/
Currently translated at 100.0% (50 of 50 strings)

Translation: fleet-16.0/fleet-16.0-fleet_vehicle_inspection_template
Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_inspection_template/it/
@petrus-v
petrus-v force-pushed the 19.0-mig-fleet_vehicle_inspection_template branch from 48a6257 to f0d47f3 Compare August 4, 2026 09:22
@petrus-v

petrus-v commented Aug 4, 2026

Copy link
Copy Markdown

@petrus-v could you please squash the administrative commits? There are quite a few commits that can be squashed.

Thanks, indeed I've squashed some of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.