[19.0][MIG] fleet_vehicle_fuel_type_ethanol: Migration to 19.0 by DenerWilliam · Pull Request #212 · OCA/fleet

DenerWilliam · 2026-01-28T02:53:28Z

Up to 19.0

Currently translated at 100.0% (10 of 10 strings) Translation: fleet-12.0/fleet-12.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-12-0/fleet-12-0-fleet_vehicle_fuel_type_ethanol/pt_BR/

Currently translated at 100.0% (5 of 5 strings) Translation: fleet-15.0/fleet-15.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_fuel_type_ethanol/it/

Currently translated at 100.0% (4 of 4 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_fuel_type_ethanol/es/

Currently translated at 100.0% (4 of 4 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_fuel_type_ethanol/sv/

marcelsavegnago · 2026-01-28T06:37:54Z

@DenerWilliam

Thanks for the contribution and welcome to OCA 🙂

Just a small note about the commit structure, following the official migration guide. According to the Migration to version 19.0 wiki, the expected flow is to first commit only the pre-commit auto-fixes, and then have a separate migration commit.
See: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

In the current state of the PR, the changes that should belong to the migration (for example, version bump and other migration tasks) were included in the [IMP] : pre-commit auto fixes commit. Because of that, there is effectively no dedicated [MIG] : Migration to 19.0 commit.

Could you please adjust the commits so that:

the pre-commit commit contains only formatting / linter auto-fixes, and

the actual migration changes are moved into a separate [MIG] commit, as described in the wiki?

This helps keep the history clean and makes reviews and future migrations much easier.

DenerWilliam · 2026-01-28T10:48:05Z

Thank you for the welcome and for the feedback 🙂
I've reorganized the history so that the [IMP] commit only contains the pre-commit auto fixes, and the migration changes are now in a separate [MIG] fleet_vehicle_fuel_type_ethanol: Migration to 19.0 commit, as requested.

marcelsavegnago · 2026-01-28T23:08:53Z

@DenerWilliam drop this please

DenerWilliam · 2026-01-29T18:37:00Z

@marcelsavegnago, done.

CristianoMafraJunior · 2026-01-30T18:45:46Z

+class FleetVehicleModel(models.Model):
+    _inherit = "fleet.vehicle.model"
+    default_fuel_type = fields.Selection(
+        selection_add=[
+            ("ethanol", "Ethanol"),
+            ("flex", "Flex (Gasoline/Ethanol)"),
+        ]
+    )
+
+


I think this code is not correct. I don’t see the need for this, since default_fuel_type is not an extensible selection field. You can remove this.

When we remove this class, the field for selecting created models still appears normal, but when we try to create a new model, the selection field comes from default.fuel.type; in this case, these two options would not appear there.

When we remove this class, the field for selecting created models still appears normal, but when we try to create a new model, the selection field comes from default.fuel.type; in this case, these two options would not appear there.

Thanks for the explanation. I understand it now — my apologies for the confusion earlier. This approach makes sense and looks fine to me.

CristianoMafraJunior · 2026-01-30T18:47:37Z

+    "version": "19.0.1.0.0",
    "license": "AGPL-3",
    "category": "Human Resources/Fleet",
    "author": "Escodoo,Odoo Community Association (OCA)",


Could you add spacing here as well? Please translate this too
"author": "Escodoo, Odoo Community Association (OCA)",

I followed the step-by-step instructions and, as indicated, did not edit the author field, keeping it exactly as it was in the project from version 18.
Regarding the translation, I chose not to perform it since it was not a blocker for the migration. In this way, I kept the existing pattern and focused only on the adaptation needed to ensure the project runs correctly in version 19.

I followed the step-by-step instructions and, as indicated, did not edit the author field, keeping it exactly as it was in the project from version 18. Regarding the translation, I chose not to perform it since it was not a blocker for the migration. In this way, I kept the existing pattern and focused only on the adaptation needed to ensure the project runs correctly in version 19.

It would just be the spacing, you know? Something simple

CristianoMafraJunior · 2026-01-30T18:49:03Z

I don’t see any blockers, but the commit name could be: f70c4e7
[MIG] fleet_vehicle_fuel_type_ethanol: Migration to 19.0

marcelsavegnago

Thanks @DenerWilliam @CristianoMafraJunior

OCA-git-bot · 2026-02-02T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

WesleyOliveira98

CODE REVIEW - OK

BhaveshHeliconia · 2026-02-04T16:34:48Z

@DenerWilliam Could you please check whether a PR already exists for a module before opening a new one?
In this case, a PR was already open before yours, and the same issue has happened with other modules in this repository as well.

PR - #198

marcelsavegnago · 2026-02-09T17:43:11Z

@BhaveshHeliconia

Apologies for this — this one is on me.
I suggested this module to @DenerWilliam as part of the migration learning process and failed to check beforehand whether there was already an open PR.

Thanks for flagging it, @BhaveshHeliconia. We’ll make sure to reinforce this check internally to avoid this happening again.

BhaveshHeliconia

@marcelsavegnago @DenerWilliam This PR can be closed, as the module has already been merged in #213.

marcelsavegnago and others added 15 commits January 27, 2026 18:58

[ADD] add fleet_vehicle_fuel_type_ethanol

ad106eb

Added translation using Weblate (Portuguese (Brazil))

e9a94ff

[IMP] fleet_vehicle_fuel_type_ethanol: black, isort, prettier

ea7c2ca

[MIG] fleet_vehicle_fuel_type_ethanol: Migration to 15.0

892c197

Added translation using Weblate (Italian)

2a767a2

Translated using Weblate (Italian)

69c1870

Currently translated at 100.0% (5 of 5 strings) Translation: fleet-15.0/fleet-15.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_fuel_type_ethanol/it/

[MIG] fleet_vehicle_fuel_type_ethanol: Migration to 16.0

7cc530f

[IMP] fleet_vehicle_fuel_type_ethanol: add contributing name

a84eddf

Added translation using Weblate (Spanish)

34731dd

Translated using Weblate (Spanish)

4a208b5

Currently translated at 100.0% (4 of 4 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_fuel_type_ethanol/es/

Added translation using Weblate (Swedish)

9a9565c

Translated using Weblate (Swedish)

f45648f

Currently translated at 100.0% (4 of 4 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_fuel_type_ethanol/sv/

[IMP] fleet_vehicle_fuel_type_ethanol: pre-commit auto fixes

62ab1e8

[MIG] fleet_vehicle_fuel_type_ethanol: Migration to 18.0

c62762e

marcelsavegnago changed the title ~~19.0 mig fleet vehicle fuel type ethanol~~ [19.0][MIG] fleet_vehicle_fuel_type_ethanol: Migration from 18.0 Jan 28, 2026

DenerWilliam force-pushed the 19.0-mig-fleet_vehicle_fuel_type_ethanol branch from 231f8ce to 12c64f3 Compare January 28, 2026 10:37

[IMP] fleet_vehicle_fuel_type_ethanol: pre-commit auto fixes

27f5346

DenerWilliam force-pushed the 19.0-mig-fleet_vehicle_fuel_type_ethanol branch from 12c64f3 to f70c4e7 Compare January 29, 2026 18:34

marcelsavegnago requested a review from CristianoMafraJunior January 30, 2026 18:21

CristianoMafraJunior reviewed Jan 30, 2026

View reviewed changes

DenerWilliam changed the title ~~[19.0][MIG] fleet_vehicle_fuel_type_ethanol: Migration from 18.0~~ [19.0][MIG] fleet_vehicle_fuel_type_ethanol: Migration to 19.0 Jan 31, 2026

[MIG] fleet_vehicle_fuel_type_ethanol: Migration to 19

8db65e5

DenerWilliam force-pushed the 19.0-mig-fleet_vehicle_fuel_type_ethanol branch from f70c4e7 to 8db65e5 Compare January 31, 2026 18:06

CristianoMafraJunior approved these changes Jan 31, 2026

View reviewed changes

marcelsavegnago approved these changes Feb 2, 2026

View reviewed changes

OCA-git-bot added the approved label Feb 2, 2026

marcelsavegnago requested a review from ivantodorovich February 2, 2026 11:58

OCA-git-bot added the ready to merge label Feb 2, 2026

WesleyOliveira98 approved these changes Feb 2, 2026

View reviewed changes

BhaveshHeliconia suggested changes Apr 24, 2026

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 24, 2026

marcelsavegnago closed this Apr 27, 2026

Uh oh!

Uh oh!

Conversation

DenerWilliam commented Jan 28, 2026

Uh oh!

marcelsavegnago commented Jan 28, 2026

Uh oh!

DenerWilliam commented Jan 28, 2026

Uh oh!

marcelsavegnago commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DenerWilliam commented Jan 29, 2026

Uh oh!

CristianoMafraJunior Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

DenerWilliam Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

CristianoMafraJunior Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

CristianoMafraJunior Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DenerWilliam Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

CristianoMafraJunior Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

DenerWilliam Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

CristianoMafraJunior commented Jan 30, 2026

Uh oh!

marcelsavegnago left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Feb 2, 2026

Uh oh!

WesleyOliveira98 left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Feb 4, 2026

Uh oh!

marcelsavegnago commented Feb 9, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

marcelsavegnago commented Jan 28, 2026 •

edited

Loading

CristianoMafraJunior Jan 30, 2026 •

edited

Loading