[17.0] [IMP] fieldservice_account_analytic: use python contrains instead of validation at creation for analytic lines - #1514
Open
rrebollo wants to merge 1 commit into
Conversation
…validation at creation for analytic lines
Contributor
|
Hi @brian10048, @osimallen, @bodedra, |
Contributor
Author
|
Failing tests are not related to this addon. |
max3903
added
needs review
series:17.0
mod:fieldservice_account_analytic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this issue after seeing the following warning:
WARNING ? odoo.api.create: The model odoo.addons.fieldservice_account_analytic.models.analytic_account is not overriding the create method in batchWhen refactoring to use
@api.model_create_multi, it became clear that a Python constraint is the more appropriate solution.@BinhexTeam T18741