Skip to content

[19.0][MIG] edi_mail_import_oca - #229

Open
etobella wants to merge 5 commits into
OCA:19.0from
dixmit:19.0-mig-mail
Open

[19.0][MIG] edi_mail_import_oca#229
etobella wants to merge 5 commits into
OCA:19.0from
dixmit:19.0-mig-mail

Conversation

@etobella

@etobella etobella commented Feb 2, 2026

Copy link
Copy Markdown
Member

Depends on #215

@etobella
etobella force-pushed the 19.0-mig-mail branch 2 times, most recently from 9b4f48e to a88067b Compare February 2, 2026 15:16
simahawk
simahawk requested changes Feb 3, 2026
View reviewed changes

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach! Thanks!

Comment thread edi_mail_import_oca/models/edi_exchange_record.py Outdated
Comment thread edi_mail_import_oca/models/edi_exchange_type.py Outdated
Comment thread edi_mail_import_oca/readme/DESCRIPTION.md
Comment thread edi_mail_import_oca/models/edi_exchange_record.py Outdated
Comment thread edi_mail_import_oca/models/edi_exchange_record.py Outdated
Comment thread edi_mail_import_oca/views/edi_exchange_type.xml Outdated
Comment thread edi_mail_import_oca/models/edi_exchange_type.py Outdated
@etobella
etobella force-pushed the 19.0-mig-mail branch 3 times, most recently from 8b6c81b to 82e92fb Compare February 4, 2026 08:31
@etobella

etobella commented Feb 4, 2026

Copy link
Copy Markdown
Member Author

@simahawk After your comments, I do agree that the best approach would be to set everything on the backend and do the same thing we do with Storage.

Also, I improved REadmes and information inside the backend to make it easier to handle (actually, it would be nice to include similar information in other modules to make it easier for users. Thanks for your comments, IMO they improved the solution.

image

@simahawk simahawk mentioned this pull request Feb 6, 2026
Closed
simahawk
simahawk reviewed Feb 6, 2026
View reviewed changes
Comment thread edi_mail_import_oca/views/edi_backend.xml Outdated
Comment thread edi_mail_import_oca/models/edi_backend.py
Comment thread edi_mail_import_oca/models/edi_exchange_record.py Outdated
Comment thread edi_mail_import_oca/models/edi_exchange_record.py Outdated
Comment thread edi_mail_import_oca/models/edi_exchange_record.py Outdated
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 14, 2026
@github-actions github-actions Bot closed this Jul 19, 2026
@etobella etobella reopened this Jul 19, 2026
@OCA-git-bot OCA-git-bot added series:19.0 mod:edi_mail_import_oca Module edi_mail_import_oca labels Jul 19, 2026
@etobella

etobella commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

@simahawk can you make a small review so we can proceed with merge?

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 26, 2026
simahawk
simahawk reviewed Jul 27, 2026
View reviewed changes

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nitpicking remarks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk requested changes

Assignees

No one assigned

Labels

mod:edi_mail_import_oca Module edi_mail_import_oca series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@etobella @simahawk @OCA-git-bot