Skip to content

[14.0][FIX] currency_rate_update_transferwise: avoid a zero-length date window #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klodr wants to merge 1 commit into
base: 14.0
Choose a base branch
from
+8 −1
Open

[14.0][FIX] currency_rate_update_transferwise: avoid a zero-length date window #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion currency_rate_update_transferwise/models/res_currency_rate_provider_TransferWise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ def _obtain_rates(self, base_currency, currencies, date_from, date_to):
since = date_from
until = since + step
while since <= date_to:
# The API answers HTTP 400 when "from" equals "to". That is
# exactly the shape of a scheduled run once the rates are up
# to date: the provider then asks for the single missing day.
# Widening the window by one day is enough — the endpoint only
# ever returns the days it actually has, so no spurious rate
# is created.
window_end = max(min(until, date_to), since + timedelta(days=1))
url = (
"https://api.transferwise.com/v1/rates"
+ "?from=%(from)s"
Expand All @@ -70,7 +77,7 @@ def _obtain_rates(self, base_currency, currencies, date_from, date_to):
"source": base_currency,
"target": currency,
"from": str(since),
"to": str(min(until, date_to)),
"to": str(window_end),
}
data = json.loads(self._transferwise_provider_retrieve(url))
if "error" in data and data["error"]:
Expand Down
Loading