[15.0][MIG] currency_rate_update_wise - #222
Open
klodr wants to merge 2 commits into
Open
Conversation
OCA-git-bot
added
mod:currency_rate_update_wise
klodr
force-pushed
the
15.0-mig-currency_rate_update_wise
branch
2 times, most recently
from
June 20, 2026 06:51
18f9dcb to
f0d3d9c
Compare
Forward-port of the renamed and hardened Wise exchange-rate provider introduced on 14.0 (rename from currency_rate_update_transferwise + security fixes; see the 14.0 history for the rationale and the OpenUpgrade rename). Framework migration only, no functional change. Signed-off-by: Claude Perrin <klodr@users.noreply.github.com>
klodr
force-pushed
the
15.0-mig-currency_rate_update_wise
branch
from
June 20, 2026 08:12
f0d3d9c to
d9ea56f
Compare
Author
|
A note on the red CI, for reviewers:
|
Wise answers HTTP 400 when the "from" and "to" query parameters are equal: GET /v1/rates?source=USD&target=EUR&from=2026-08-04&to=2026-08-04&group=day -> 400 Bad Request That is exactly the shape of a scheduled run once the rates are up to date: the provider then asks for the single missing day. The failure is therefore intermittent — it only shows up when no more than one day is missing, which is the steady state of a daily cron. Widen the window by one day when it would collapse. The endpoint only returns the days it actually has, so no spurious rate is created; asking for a "to" one day ahead of today answers 200 with today's rate only. The existing tests mock the HTTP layer and never inspect the outgoing query, which is why this went unnoticed. Add a test that captures the parameters and asserts the window is never zero-length. Signed-off-by: Claude Perrin <klodr@users.noreply.github.com> (cherry picked from commit bac73b5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currency_rate_update_wise→ 15.0Forward-port of the Wise.com exchange-rate provider from 14.0 to 15.0.
Framework migration only, no functional change.
Notes for reviewers
_wise_provider_retrieve) is mocked —no network access needed in CI.
API token still uses the legacy UUID format (Wise UUID → JWT migration).