[14.0] pre-commit: bump setuptools-odoo to 3.3.2 to fix pkg_resources ImportError - #221
Open
klodr wants to merge 1 commit into
Open
[14.0] pre-commit: bump setuptools-odoo to 3.3.2 to fix pkg_resources ImportError#221klodr wants to merge 1 commit into
klodr wants to merge 1 commit into
Conversation
… ImportError setuptools-odoo 3.1.8 imports the removed `pkg_resources` module, so the `setuptools-odoo-make-default` and `setuptools-odoo-get-requirements` hooks fail with `ModuleNotFoundError: No module named 'pkg_resources'` on recent setuptools (>= 81). This makes the pre-commit check red on every PR currently opened against this branch. Bump the hook to 3.3.2, same as OCA#217 for 16.0. Signed-off-by: Claude Perrin <klodr@users.noreply.github.com>
Author
|
@OCA/currency-maintainers could you please review? This is the 14.0 counterpart of #217: bump |
This was referenced Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools-odoo3.1.8 imports the removedpkg_resourcesmodule, so thesetuptools-odoo-make-defaultandsetuptools-odoo-get-requirementspre-commit hooks fail withModuleNotFoundError: No module named 'pkg_resources'on recent setuptools (>= 81). Thepre-commitcheck is therefore red on every PR currently opened against14.0.Bump the hook to
3.3.2, the same fix as #217 (16.0).