[18.0][FIX] account_statement_import_camt: TxDtls amounts not equals to Ntry amount - #976
Open
jguenat wants to merge 1 commit into
Open
Conversation
OCA-git-bot
added
series:18.0
mod:account_statement_import_camt
Member
Author
|
@ecino Did this happened to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an issue where the imported bank statement lines where not correct.
Is some cases, e.g payment fees (Chrgs...), the sum of TxDtls/amt is not equals to the Ntry/Amt.
exemple
Ntry/Amt 1526
Ntry/NtryDtls/TxDtls/Amt 1500
Ntry/NtryDtls/TxDtls/Chrgs/Rcrd/Amt 26
The issue with the current implementation is that 1526 will be lost and replaced by 1500. The statement line is then wrong by 26.
One solution would have been to look for Amt in Chrgs but I was not able to find a standard for this.
The chosen approach is to check if the sum of all TxDtls is equals to the Ntry/Amt. If not then add the difference to the bigger TxDtls. The advantage of this is to cover other cases that might happen (other fees....) across different banks CAMT implementation.
Also add the Chrgs info to the narration.