[FIX] account_statement_import_sheet_file: Apply fixes on top of OCA 19.0 migration - #957
Closed
cav-adhoc wants to merge 2 commits into
Closed
[FIX] account_statement_import_sheet_file: Apply fixes on top of OCA 19.0 migration#957cav-adhoc wants to merge 2 commits into
cav-adhoc wants to merge 2 commits into
Conversation
Contributor
|
Hi @alexey-pelykh, |
OCA-git-bot
added
mod:account_statement_import_sheet_file
cav-adhoc
force-pushed
the
19.0-fix-account_statement_import_sheet_file
branch
from
May 22, 2026 18:56
f8844c2 to
6c3e6e0
Compare
…19.0 migration - Add openpyxl support for .xlsx files (OCA only kept xlrd/.xls format) - Fix integer values in column concatenation (_get_values_from_column) - Add case-insensitive column name matching in _get_column_indexes - Use str() cast in _parse_decimal to handle non-string cell values - Remove duplicate amount_column field definition (OCA bug in PR OCA#907) - Fix typo in amount_type help text ("igned" -> "signed") - Add _clear_amount_columns onchange to clear irrelevant fields on type change - Remove data/map_data.xml from data list (keep as demo only); no impact on existing databases since the record and its XML ID remain in place - Create sample_statement_map inline in tests with .create() instead of env.ref() so tests run independently of demo data - Update tests to use BaseCommon and cover xlsx/openpyxl scenarios - Add missing Tecnativa and BCIM copyrights to parser and tests
cav-adhoc
force-pushed
the
19.0-fix-account_statement_import_sheet_file
branch
from
May 22, 2026 18:58
6c3e6e0 to
566dc90
Compare
cav-adhoc
changed the title
cav-adhoc
force-pushed
the
19.0-fix-account_statement_import_sheet_file
branch
2 times, most recently
from
May 22, 2026 19:25
e02410c to
3387480
Compare
|
We are currently working on a refactoring of this module so that we can extend the this module, which by default will only work with CSV files. This gives us greater flexibility and the option to use modules to add the ability to import XLS and XLSX and other files. |
feg-adhoc
force-pushed
the
19.0-fix-account_statement_import_sheet_file
branch
from
May 26, 2026 14:01
3387480 to
1c651a7
Compare
… header_lines_skip_count
feg-adhoc
force-pushed
the
19.0-fix-account_statement_import_sheet_file
branch
from
May 27, 2026 12:33
1c651a7 to
d7d6f5b
Compare
Member
|
Replaced by #969 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies ADHOC-specific fixes and improvements on top of the OCA 19.0 migration (merged via #907), replacing the
previous ADHOC PR #894.
Changes included
Bug fixes from ADHOC PRs #870 / #894 not included in OCA #907:
openpyxl → CSV so modern Excel files continue to work. Affects parse_header, _parse_lines, and _parse_rows.
concatenating multiple columns, preventing a crash when xlrd/openpyxl returns numeric types.
case-insensitive before raising ValueError.
crashing.
Model fixes:
invalid configurations.
Tests:
Replaces
This PR replaces #894 (which was based on a pre-#907 migration). The previous PR should be closed.
🤖 Generated with Claude Code