Skip to content

[account_statement_import_online_plaid] Exclude pending transactions #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel15 wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Open

[account_statement_import_online_plaid] Exclude pending transactions #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
778c625
[account_statement_import_online_plaid] Exclude pending transactions
Daniel15 May 17, 2026
ca313eb
Merge branch 'OCA:18.0' into plaid-no-pending
Daniel15 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions account_statement_import_online_plaid/models/online_bank_statement_provider_plaid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,5 @@ def _prepare_vals_for_statement(self, transactions):
"raw_data": transaction,
}
for transaction in transactions
if not transaction.get("pending")
]
8 changes: 8 additions & 0 deletions account_statement_import_online_plaid/tests/test_account_statement_import_online_plaid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright 2024 Binhex - Adasat Torres de León.
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
import datetime
from copy import deepcopy
from unittest.mock import MagicMock, patch

from odoo.tests import common
Expand Down Expand Up @@ -189,6 +190,13 @@ def test_import_online_bank_statement_plaid(self, trasactions_get):
self.assertEqual(lines[0].amount, -500.0)
self.assertEqual(lines[1].amount, -30.0)

def test_prepare_vals_for_statement_skips_pending_transactions(self):
transactions = deepcopy(TRANSACTIONS)
transactions[0]["pending"] = True
vals = self.provider._prepare_vals_for_statement(transactions)
self.assertEqual(len(vals), 1)
self.assertEqual(vals[0]["unique_import_id"], transactions[1]["transaction_id"])

def test_get_services(self):
services = self.provider._get_available_services()
self.assertTrue(services)
Expand Down
Loading