[19.0][MIG] account_statement_import_ofx: Migration to 19.0 - #924
Open
kwoychesko wants to merge 17 commits into
Open
[19.0][MIG] account_statement_import_ofx: Migration to 19.0#924kwoychesko wants to merge 17 commits into
kwoychesko wants to merge 17 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:account_statement_import_ofx
Contributor
|
This PR has the |
Contributor
Author
|
Hey all! Thanks very much for reviewing! Do we know who has rights to merge this? I don't see any "maintainers" listed for it. |
Rename module to account_statement_import_ofx Add support for multi-account OFX files
Currently translated at 57.1% (4 of 7 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_ofx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_ofx/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_ofx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_ofx/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_ofx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_ofx/fr/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_ofx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_ofx/pt_BR/
Currently translated at 75.0% (3 of 4 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_ofx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_ofx/it/
Use with statement to open files Change misleading variable names
Fix and extend tests to address codecov/patch failures: - Enable previously disabled IBAN import test (was prefixed no_test_) and fix bank account number to match OFX ACCTID field - Add test for checknum and memo fields in payment_ref construction - Add test for _parse_file error handling (UserError on bad data) - Add test for non-OFX file fallback to super()._parse_file - Add OFX fixture with CHECKNUM and MEMO transaction fields
- Reformat test file with ruff-format (default line length 88) - Add missing trailing newline to OFX test fixture
Calling _parse_file with non-OFX data cascades through the CAMT parser which logs an ERROR for BadZipFile, causing the OCA CI log checker to fail. Test _check_ofx directly instead.
Ensure a suspense account exists on the company before creating test journals. Without this, bank statement line creation fails with: "You can't create a new statement line without a suspense account set on the journal."
kwoychesko
force-pushed
the
19.0-mig-account_statement_import_ofx
branch
from
July 27, 2026 20:08
3576d13 to
861d961
Compare
Contributor
Author
|
Does anyone know the maintainers of this module? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to 19.0
Standard migration, no structural changes required — the upstream API (
account_statement_import_file) was stable between 18.0 and 19.0.Changes
_()withself.env._()for lazy translation (per [IMP] core: Environment._ for translations and LazyTranslate odoo/odoo#174844)requirements.txtviaoca-gen-external-dependencies