Skip to content

[FIX] account_statement_import_sheet_file: Handle integer values in column concatenation #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cav-adhoc wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+6 −1
Open

[FIX] account_statement_import_sheet_file: Handle integer values in column concatenation #893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,12 @@ def _get_values_from_column(self, values, columns, column_name):
content_l.append(values[index])
if all(isinstance(content, str) for content in content_l):
return " ".join(content_l)
return content_l[0]
elif any(isinstance(content, int) for content in content_l):
# Convert all content to string and join when we have integers
Comment thread
cav-adhoc marked this conversation as resolved.
return " ".join(str(content) for content in content_l)
Comment thread
cav-adhoc marked this conversation as resolved.
else:
# Fallback to first content for other mixed types
return content_l[0]

def _parse_rows(self, mapping, currency_code, data, columns): # noqa: C901
csv_or_xlsx, data_file = data
Expand Down