Skip to content

[18.0][ADD] payment_require_legal: New module - #964

Open
pilarvargas-tecnativa wants to merge 1 commit into
OCA:18.0from
Tecnativa:18.0-ad--payment_require_legal
Open

[18.0][ADD] payment_require_legal: New module#964
pilarvargas-tecnativa wants to merge 1 commit into
OCA:18.0from
Tecnativa:18.0-ad--payment_require_legal

Conversation

@pilarvargas-tecnativa

@pilarvargas-tecnativa pilarvargas-tecnativa commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

From the link:
image

From the portal:

image

@Tecnativa TT63899

@carlos-lopez-tecnativa @victoralmau @pedrobaeza please review

@OCA-git-bot OCA-git-bot added series:18.0 mod:payment_require_legal Module payment_require_legal labels Jul 29, 2026
@pedrobaeza pedrobaeza added this to the 18.0 milestone Jul 29, 2026
@pedrobaeza

This comment was marked as resolved.

@pilarvargas-tecnativa

This comment was marked as resolved.

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected when using a payment link or the portal. However, when I install website_sale, the /shop/payment page does not work.

If this module is not intended to cover this case, could you try hiding the terms and conditions on this page, if possible? Otherwise, please add this limitation to the ROADMAP.

Image

@pedrobaeza

Copy link
Copy Markdown
Member

What does not work mean? Is it not blocking the payment?

@carlos-lopez-tecnativa

Copy link
Copy Markdown
Contributor

What does not work mean? Is it not blocking the payment?

As you can see in the image, I did not accept the terms and conditions, but the button is still enabled. In the other payment flows, the button remains disabled until the terms and conditions are accepted.

@pilarvargas-tecnativa

pilarvargas-tecnativa commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

As you can see in the image, I did not accept the terms and conditions, but the button is still enabled. In the other payment flows, the button remains disabled until the terms and conditions are accepted.

In that case, it needs to be hidden for the checkout process, as Odoo includes the checkbox by default in this workflow, but the option needs to be enabled in the editor. I’ll look into it, thanks

@pilarvargas-tecnativa
pilarvargas-tecnativa force-pushed the 18.0-ad--payment_require_legal branch from f4550bf to 9335e5c Compare July 29, 2026 14:58
@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor Author

@carlos-lopez-tecnativa done!

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:payment_require_legal Module payment_require_legal series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants