[18.0][FIX] account_payment_return_import_iso20022: Search payments by ID instead of move_id - #955
Open
carlos-lopez-tecnativa wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:18.0
mod:account_payment_return_import_iso20022
Member
|
Please look for both, as we may have old payment orders. |
carlos-lopez-tecnativa
force-pushed
the
18.0-fix-account_payment_return_import_iso20022-match-reference
branch
from
June 23, 2026 14:55
950f8cf to
1029d18
Compare
Contributor
Author
Done. Please let me know if this is OK for you. |
pedrobaeza
reviewed
Jun 23, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
You can better swap the search order. I'm now fearing that there's a choke between the IDs of both tables in any moment (but that's not your fault, but the change of criteria).
…nstead of move_id After this PR OCA/bank-payment#1475, the EndToEndId is generated using the payment ID instead of the journal entry (move) ID. As a result, when importing an payment return XML file, the payment can no longer be matched correctly because the lookup is still performed using the move_id.
carlos-lopez-tecnativa
force-pushed
the
18.0-fix-account_payment_return_import_iso20022-match-reference
branch
from
June 23, 2026 15:09
1029d18 to
a638662
Compare
pedrobaeza
reviewed
Jun 23, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Now thinking twice, this may return incorrect results due to the choke I have mentioned. Do we simply break compatibility with older payments? What others think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR OCA/bank-payment#1475, the
EndToEndIdis generated using the payment ID instead of the journal entry (move) ID.As a result, when importing an payment return XML file, the payment can no longer be matched correctly because the lookup is still performed using the move_id.
TT63378
@Tecnativa @pedrobaeza @carlosdauden @sergio-teruel could you please review this?