[19.0][MIG] account_payment_show_invoice: Migration to 19.0 - #940
Open
dnplkndll wants to merge 11 commits into
Open
[19.0][MIG] account_payment_show_invoice: Migration to 19.0#940dnplkndll wants to merge 11 commits into
dnplkndll wants to merge 11 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:account_payment_show_invoice
dnplkndll
force-pushed
the
19.0-mig-account_payment_show_invoice
branch
from
May 20, 2026 17:12
b536968 to
ae44e78
Compare
Author
|
@JasminSForgeFlow @manuelcalerosolis basic MIG |
JasminSForgeFlow
approved these changes
May 21, 2026
BhaveshHeliconia
approved these changes
May 28, 2026
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Code review LGTM!
Contributor
|
@dnplkndll Please squash the commits as explained here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate |
Contributor
|
This PR has the |
dnplkndll
force-pushed
the
19.0-mig-account_payment_show_invoice
branch
from
May 28, 2026 12:26
ae44e78 to
09606f5
Compare
There was a fix in `account_payment` module that changed the way how `multi` field is computed. In the case of `test_2_two_invoices_register_payment` in `account_payment_multi_deduction` module, it's evaluated to True and this made the payment registration `amount` field readonly. https://github.com/odoo/odoo/blob/867de2bad3f6096098cb47611bcf0096b85e24b8/addons/account/models/account_payment.py#L303 Now, this operation raises an error. https://github.com/OCA/account-payment/blob/4f7c56d8f501dde75a04f61076a27d2b011274c0/account_payment_multi_deduction/tests/test_payment_multi_deduction.py#L99 https://travis-ci.org/github/OCA/account-payment/jobs/658790207#L1020 multi=True caused this error too as the payment register is not grouping invoices https://travis-ci.org/github/OCA/account-payment/jobs/658790207#L1109
dnplkndll
force-pushed
the
19.0-mig-account_payment_show_invoice
branch
from
May 29, 2026 00:18
09606f5 to
f406c0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
account_payment_show_invoicefrom 18.0 to 19.0. Follows the OCA migration guide.