Repository navigation
fix(explain): document the route lookup flagged by gosec G704 - #19
Merged
Merged
Conversation
tunnelInterfaceFor connects a UDP socket only to learn which interface the kernel would route the target through; nothing is sent, and the address is the host the operator asked to probe. Annotate it like the repository's other justified exceptions.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis red since #18: gosec's G704 (SSRF taint) flags thenet.Dial("udp", ...)intunnelInterfaceFor. It is a route lookup only — connecting a UDP socket sends nothing — and the address is the host the operator asked to probe. Annotated with#nosec G704and the justification, like the repository's other exceptions.Checklist
gofmt -l .produces no outputgo vet ./...passesTest plan
Ran
ghcr.io/securego/gosec@sha256:a6cd2f30…with the CI's arguments on this branch: 0 issues.