fix: use dynamic id for aria-controls in PasswordToggle.vue#36
Open
lajczi wants to merge 1 commit into
Open
Conversation
Owner
|
Looks like a great fix! I just want to confirm - have you tested whether it causes any hydration errors? I don’t think it will, but it’d be great to verify. |
Contributor
Author
naturally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
aria-controls="password"in PasswordToggle.vue referenced a hardcoded element id that didn't exist in the DOM causing accessibility violations flagged by lighthouse.Fixed by generating a unique ID with Vue's
useId()composable and binding it both to theUInputelement andaria-controls, so the button correctly points to the actual input it controls