Skip to content

jfr-converter: init at 4.4#510258

Open
JarvisCraft wants to merge 1 commit into
NixOS:masterfrom
JarvisCraft:jfr-converter/init
Open

jfr-converter: init at 4.4#510258
JarvisCraft wants to merge 1 commit into
NixOS:masterfrom
JarvisCraft:jfr-converter/init

Conversation

@JarvisCraft
Copy link
Copy Markdown
Contributor

@JarvisCraft JarvisCraft commented Apr 15, 2026 •
edited
Loading

Initialize async-profiler's jfr-converter utility at 4.4.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Apr 15, 2026
@JarvisCraft
Copy link
Copy Markdown
Contributor Author

JarvisCraft commented Apr 15, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 510258
Commit: d0160552bedaae0d3502e5c117cfa903a78826e0

x86_64-linux

✅ 1 package built:
  • jfr-converter

jackrosenberg
jackrosenberg reviewed Apr 15, 2026
View reviewed changes
Comment thread pkgs/by-name/jf/jfr-converter/package.nix Outdated
@jackrosenberg
Copy link
Copy Markdown
Member

jackrosenberg commented Apr 15, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 510258
Commit: d0160552bedaae0d3502e5c117cfa903a78826e0

x86_64-linux

✅ 1 package built:
  • jfr-converter

@jackrosenberg
Copy link
Copy Markdown
Member

jackrosenberg commented Apr 15, 2026

The PR is failing nixpkgs-vet on:

Attribute `pkgs.jfr-converter` is a new package with `strictDeps` unset or set to `false`.
       >   Please enable `strictDeps = true;` in pkgs/by-name/jf/jfr-converter/package.nix.
       >  (NPV-164)
       > - Attribute `pkgs.jfr-converter` is a new package with `__structuredAttrs` unset or set to `false`.
       >   Please enable `__structuredAttrs = true;` in pkgs/by-name/jf/jfr-converter/package.nix.
       >  (NPV-166)

see #509970 and https://nixos.org/manual/nixpkgs/unstable/#var-stdenv-strictDeps :)

@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Apr 15, 2026
@JarvisCraft
Copy link
Copy Markdown
Contributor Author

JarvisCraft commented Apr 16, 2026

Thanks for the review and reference, all fixed now

jackrosenberg
jackrosenberg approved these changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jackrosenberg jackrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JarvisCraft
Copy link
Copy Markdown
Contributor Author

JarvisCraft commented Apr 16, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 510258
Commit: ce34ff3850d856c01736987f0084bf0160a6c97d

x86_64-linux

✅ 1 package built:
  • jfr-converter

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 16, 2026
@JarvisCraft JarvisCraft changed the title jfr-converter: init at 4.3 jfr-converter: init at 4.4 Apr 23, 2026
@JarvisCraft JarvisCraft force-pushed the jfr-converter/init branch from 855e2c2 to 4e12efb Compare May 7, 2026 11:34
@JarvisCraft
Copy link
Copy Markdown
Contributor Author

JarvisCraft commented May 7, 2026 •
edited
Loading

Updated the PR to use finalAttrs now that it is available for buildMavenPackage

@nixpkgs-ci nixpkgs-ci Bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jackrosenberg jackrosenberg jackrosenberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JarvisCraft @jackrosenberg