Skip to content

buildEnv: add support for __structuredAttrs & strictDeps#509888

Closed
doronbehar wants to merge 1 commit into
NixOS:masterfrom
doronbehar:pkg/buildEnv@structured
Closed

buildEnv: add support for __structuredAttrs & strictDeps#509888
doronbehar wants to merge 1 commit into
NixOS:masterfrom
doronbehar:pkg/buildEnv@structured

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented Apr 14, 2026 •
edited
Loading

Needed for:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@doronbehar
buildEnv: add support for __structuredAttrs & strictDeps
b6ae3c1 
Enable adding new packages to nixpkgs that are defined using buildEnv,
without triggering new nixpkgs-vet CI failures. See:

NixOS/nixpkgs-vet#203

In the future, enable `__structuredAttrs` and `strictDeps` by default.
@doronbehar doronbehar mentioned this pull request Apr 14, 2026
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci Bot requested a review from philiptaron April 14, 2026 10:49
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 14, 2026
jopejoe1
jopejoe1 requested changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jopejoe1 jopejoe1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildEnv recently got a refactor merged into staging, And the changes here are in conflict with the changes done in staging/staging-next.

See #432957 and #434815 for those changes.

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Apr 14, 2026

buildEnv recently got a refactor merged into staging, And the changes here are in conflict with the changes done in staging/staging-next.

See #432957 and #434815 for those changes.

Thanks for the links. Indeed the changes here are probably redundant and will most certainly conflict. I will check if I still have an issue in #509199 when these PRs will reach master.

@doronbehar doronbehar closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jopejoe1 jopejoe1 jopejoe1 requested changes

@Artturin Artturin Awaiting requested review from Artturin

@ShamrockLee ShamrockLee Awaiting requested review from ShamrockLee

@philiptaron philiptaron Awaiting requested review from philiptaron

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doronbehar @jopejoe1