Merged
Conversation
one-d-wide
approved these changes
Mar 9, 2026
Contributor
one-d-wide
left a comment
There was a problem hiding this comment.
LGTM. They don't seem to rush updating WAMR to newer LLVM versions any time soon.
bytecodealliance/wasm-micro-runtime#4654
69f1840 to
6eda008
Compare
This build was failing due to needing access to files outside the `wamr-compiler` directory, so we `cd` into the build directory instead of using `sourceRoot`. Additionally, this fails to link with LLVM 21, so we override the LLVM version to override it to LLVM 20. Example failing Hydra build: https://hydra.nixos.org/build/314568884
6eda008 to
d8c1224
Compare
szympajka
approved these changes
Mar 17, 2026
Contributor
szympajka
left a comment
There was a problem hiding this comment.
Builds and works on aarch64-darwin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: bytecodealliance/wasm-micro-runtime@WAMR-2.3.1...WAMR-2.4.4
Release notes: Lots, see https://github.com/bytecodealliance/wasm-micro-runtime/releases
This build was failing due to needing access to files outside the
wamr-compilerdirectory, so wecdinto the build directory instead of usingsourceRoot.Additionally, this fails to link with LLVM 21, so we override the LLVM version to override it to LLVM 20. Example failing Hydra build: https://hydra.nixos.org/build/314568884
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.