haskellPackages.http2-client: fix w/ current http2, tls, network#386711
Merged
maralorn merged 1 commit intoMar 3, 2025
Conversation
github-actions
Bot
added
the
6.topic: haskell
github-actions
Bot
added
10.rebuild-darwin: 1-10
maralorn
reviewed
Mar 3, 2025
Comment on lines
+2741
to
+2747
| http2-client = appendPatches [ | ||
| (fetchpatch { | ||
| name = "http2-client-fix-build-with-http2-5.2.patch"; | ||
| url = "https://github.com/haskell-grpc-native/http2-client/commit/952a57d1138dc31863a5e387dbda67cbdfcfd9f4.patch"; | ||
| sha256 = "1q0n7338rjz7zl6xpw51lljp7xw1gl128s1d5877kfil3fc23npp"; | ||
| }) super.http2-client; | ||
| name = "http2-client-fix-build-with-http2-5.3.patch"; | ||
| url = "https://github.com/haskell-grpc-native/http2-client/pull/97/commits/95143e4843253913097838ab791ef39ddfd90b33.patch"; | ||
| sha256 = "09205ziac59axld8v1cyxa9xl42srypaq8d1gf6y3qwpmrx3rgr9"; | ||
| }) | ||
| ] (doJailbreak super.http2-client); |
Member
Author
There was a problem hiding this comment.
I originally also picked the patch relaxing the tls bound from haskell-grpc-native/http2-client#97, but the network bound is also too strict so I decided I wouldn't bother and just jailbreak.
9999years
reviewed
Mar 3, 2025
| sha256 = "1q0n7338rjz7zl6xpw51lljp7xw1gl128s1d5877kfil3fc23npp"; | ||
| }) super.http2-client; | ||
| name = "http2-client-fix-build-with-http2-5.3.patch"; | ||
| url = "https://github.com/haskell-grpc-native/http2-client/pull/97/commits/95143e4843253913097838ab791ef39ddfd90b33.patch"; |
Contributor
There was a problem hiding this comment.
URLs like this can break when the PR is force-pushed, might want to do this instead:
Suggested change
| url = "https://github.com/haskell-grpc-native/http2-client/pull/97/commits/95143e4843253913097838ab791ef39ddfd90b33.patch"; | |
| url = "https://github.com/haskell-grpc-native/http2-client/commit/95143e4843253913097838ab791ef39ddfd90b33.patch"; |
Member
Author
There was a problem hiding this comment.
Even with the alternative the link it'll break on force pushes since GitHub usually gcs the commit iirc?
Contributor
There was a problem hiding this comment.
Not sure. We've had better luck with URLs like this but nothing is certain.
Member
There was a problem hiding this comment.
In my experience the recommended change is more stable. It‘s not rock solid according to reports I‘ve heard, but it’s the best we can do.
9999years
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.