kicad-unstable: 2023-04-14 -> 2023-06-24#232600
Merged
Merged
Conversation
github-actions
Bot
added
the
6.topic: python
evils
force-pushed
the
kicad-unstable
branch
3 times, most recently
from
2df8ea0 to
4dacf4c
Compare
ofborg
Bot
added
8.has: package (new)
Member
Author
|
a big thanks to hexa for getting the python packages' tests running |
Member
Author
|
upstreaming the diffimg fix has been started |
evils
changed the title
Member
Author
|
bumped to latest commit |
aidalgol
approved these changes
Jun 25, 2023
aidalgol
left a comment
aidalgol
left a comment
Contributor
There was a problem hiding this comment.
I'm not familiar with KiCad, but these changes look perfectly sane to me.
evils
force-pushed
the
kicad-unstable
branch
2 times, most recently
from
dddcd02 to
8d5585e
Compare
SuperSandro2000
requested changes
Jun 26, 2023
new qa_cli test needs pytest-image-diff it also accesses $HOME, so setting that as well and it checks for a valid commit which is exposed to the end-user via kicad-cli version --format=commit so i'm setting the placeholder to the actual commit used mostly to avoid doing a leaveDotGit and rewriting update.sh
SuperSandro2000
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
bump to latest master commit
which now has
qa_clitests, which requirepytest-image-diff, which requiresimgdiffanddiffimg(i initially packaged
image-diffinstead which is not needed, but it's packaged now...)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)