Send a new event if the user closes the prompt#454
Open
yoann-chambrun wants to merge 7 commits intoNiklasMerz:masterfrom
Open
Send a new event if the user closes the prompt#454yoann-chambrun wants to merge 7 commits intoNiklasMerz:masterfrom
yoann-chambrun wants to merge 7 commits intoNiklasMerz:masterfrom
Conversation
NiklasMerz
requested changes
Dec 9, 2022
Owner
NiklasMerz
left a comment
NiklasMerz
left a comment
There was a problem hiding this comment.
Thanks for making the changes. Please check out the comment for the version.
Maybe a minor release is fine, too. This just adds a new error that needs to be handled.
@yoann-chambrun If you didn't now: You can just push changes to your branch and the PR will update. No need to create a new PR.
| { | ||
| "name": "cordova-plugin-fingerprint-aio", | ||
| "version": "5.0.1", | ||
| "version": "5.1.0", |
Owner
There was a problem hiding this comment.
Suggested change
| "version": "5.1.0", | |
| "version": "5.0.1", |
Please don't change versions in PRs. It's part of the release process.
NiklasMerz
requested changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Send a new event if the user close the biometrics modal.
A new event has been added, just a minor version is needed for me.
How did you test your changes?