iOS only: Fixed isAvailable to return error code rather than generic …#227
Open
jainank wants to merge 3 commits intoNiklasMerz:masterfrom
Open
iOS only: Fixed isAvailable to return error code rather than generic …#227jainank wants to merge 3 commits intoNiklasMerz:masterfrom
jainank wants to merge 3 commits intoNiklasMerz:masterfrom
Conversation
Owner
|
Rebased. Looks like a breaking changed. Milestone set to next major version |
exxbrain
reviewed
Feb 27, 2020
Contributor
exxbrain
left a comment
exxbrain
left a comment
There was a problem hiding this comment.
As I see codeclimate errors should be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed #226 , where isAvailable function in iOS returns generic error rather than specific error
How did you test your changes?
Tested the changes on my personal application.
I tried to run test-ios, but seems like some issue with my simulator which is throwing error to run the app. However when I tested with my production application, it works perfectly.