Skip to content

Fix mock_DeviceModel defaulting manufacturer to None #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HugoFara wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix mock_DeviceModel defaulting manufacturer to None #2232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# PyNWB Changelog

## PyNWB 4.1.1 (Unreleased)

### Fixed
- Fixed `mock_DeviceModel` defaulting `manufacturer` to `None`, which made every call raise `TypeError: DeviceModel.__init__: None is not allowed for 'manufacturer'` because `DeviceModel` requires `manufacturer` to be a `str`. The mock now defaults it to `"manufacturer"`, matching the other mock defaults, and is covered by the parametrized `test_mock`/`test_mock_write` tests. @HugoFara [#2232](https://github.com/NeurodataWithoutBorders/pynwb/pull/2232)


## PyNWB 4.1.0 (July 23, 2026)

### Changed
Expand Down
2 changes: 1 addition & 1 deletion src/pynwb/testing/mock/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def mock_Device(

def mock_DeviceModel(
name: Optional[str] = None,
manufacturer: str = None,
manufacturer: str = "manufacturer",
model_number: Optional[str] = None,
description: str = "description",
nwbfile: Optional[NWBFile] = None,
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/test_mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
mock_OptogeneticSeries
)

from pynwb.testing.mock.device import mock_Device
from pynwb.testing.mock.device import mock_Device, mock_DeviceModel

from pynwb.testing.mock.behavior import (
mock_Position,
Expand Down Expand Up @@ -68,6 +68,7 @@
mock_OptogeneticStimulusSite,
mock_OptogeneticSeries,
mock_Device,
mock_DeviceModel,
mock_Position,
mock_PupilTracking,
mock_CompassDirection,
Expand Down