Repository navigation
fix(brand): size large CodeNomad logos by their title - #1108
Merged
Merged
Conversation
With the bare CN mark, the large logos grew with the window and looked oversized: the home page switched from 8rem to 12rem from 640 x 721 px, the branded empty session showed 12rem (9rem in narrow columns) and the loading screen 180 px. The owner wants them no larger than the home page's compact size. The home page logo stays 8rem at every window size (the 12rem media rule and the redundant 8rem override go; the compact hero margin stays), the branded empty session uses 8rem (h-32) with no narrow-column override, and the loading screen shows the logo 8rem (128 px) wide. The plain empty state already uses 6rem. Validated live in the owner's installed app with an 8rem override on the home page and empty session, and with the UI typecheck.
Contributor
Author
Review: zero findingsReviewed commit
|
The owner set the reference on the plain empty state: a 6rem logo above its text-3xl title. Large logos now follow their title instead of a fixed 8rem: the home page and the branded empty session use 6rem beside the same text-3xl title, and the narrow session column, whose title shrinks to 1.5rem, shows the logo at 4.8rem, the same 3.2 ratio. The loading screen keeps 8rem beside its larger 2.8rem title. dev-docs/UI_CONVENTIONS.md records the rule so a logo changes with its title and never with the window. Validated by rendering the real home page, branded and plain empty states, the narrow session column and the loading screen in dark and light themes at 1100 x 760: logo/title 96/30 px, 96/30 px, 96/30 px, 76.8/24 px and 128/44.8 px. The owner's installed app shows the same sizes through a temporary override; the UI typecheck passes.
Contributor
Author
Round 2 —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Large logos follow their title instead of the window, on the plain empty state's ratio (6rem logo above a
text-3xltitle, 3.2x):h-48).dev-docs/UI_CONVENTIONS.mdrecords the rule.Validation
npm run typecheck --workspace @codenomad/ui.