Repository navigation
feat(notifications): show Clear all and Settings as icons in the history - #1107
Conversation
Findings
No functional findings. Accessible names and tooltips reuse existing translations; icons are hidden from assistive technology and render at the shared 14px size. Opening still focuses Close, followed by Mark all read, Clear all, and Settings. The shared/local stylesheet order preserves the idle danger color and visible keyboard focus; hover text becoming the primary color also occurs with the existing text-button styling. Searches found no tests, skills, or developer documentation depending on the removed text content. Validation
Repository files were not modified. |
|
Round 2 review of
The round-1 finding is resolved: all ten locales identify the notification-history shortcut as a gear and use their exact Validation: |
The notification history's action row showed "Clear all" (with a small trash icon) and "Settings" as text buttons, which made the row heavy next to the filters. They are now icon buttons, like the panel's close button: a red trash can for Clear all and a gear for Settings. Their labels stay as tooltips and accessible names, translated as before. "Mark all as read" keeps its text. Both buttons use the shared window-icon-button geometry; the existing toast-history action classes keep their hover, danger and disabled treatment. Validated with screenshots of the real ToastHistoryPanel with two notifications in dark and light themes (icons, hover state) and the UI typecheck.
The Settings shortcut in the notification history is now an icon-only gear whose label is its tooltip, so the Settings help names it as the Settings gear, in all ten languages, with each locale's UI label. Validated with the help test.
45bf232 to
12a6f7c
Compare
Summary
title) and accessible names (aria-label), with the existing translations. Mark all as read keeps its text.window-icon-buttongeometry; the existing toast-history action classes keep hover, danger and disabled styling.Validation
ToastHistoryPanelwith two notifications, dark and light themes, including the hover state.npm run typecheck --workspace @codenomad/ui.