Repository navigation
feat(titlebar): show the CodeNomad mark instead of the window title - #1102
Merged
Merged
Conversation
The main window's custom title bar on Windows and Linux showed the text "CodeNomad" before its menus. It now shows the new CN mark, so the brand reads as a logo next to File, Edit, View, Window and Help. The Preferences window keeps its text title. NativeTitlebar gains an optional logo prop: when set, it renders packages/ui/src/images/CodeNomad-Mark.svg (the mark from images/CodeNomad-Icon.svg cropped to its bounds) 24 px high, centred in the 36 px bar, with the title as its alt text so the accessible name stays "CodeNomad". The image is not draggable, so pressing it still moves the window instead of starting an image drag, and it hides below 640 px like the title did. BUILD.md lists the cropped asset beside its source. Validated with the UI typecheck and screenshots of the real NativeTitlebar at 1x and 2x in dark and light themes (mark 24x45.5 px, alt "CodeNomad", Preferences title unchanged).
Contributor
Author
ReviewZero findings (P0–P3) on commit
File-size note: |
pascalandr
added a commit
that referenced
this pull request
Oct 22, 2026
## Summary - The title-bar mark from #1102 goes from 24 px to **20 px** high, at the owner's request: 8 px of margin above and below it in the 36 px bar, closer to the weight of the menu labels. - Only `.native-titlebar-logo` height changes; the brand container still centres it vertically. ## Validation - Screenshot of the real `NativeTitlebar` at 20 px in dark and light themes, 1x and 2x: mark 20×38 px at y=8 in the 36 px bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NativeTitlebargains an optionallogoprop: it renderspackages/ui/src/images/CodeNomad-Mark.svg(the mark fromimages/CodeNomad-Icon.svgcropped to its bounds) 24 px high, centred in the 36 px bar, with the title asaltso the accessible name stays "CodeNomad".draggable={false}so pressing it still moves the window, and it hides below 640 px like the title did.BUILD.mdlists the cropped asset beside its source.Validation
npm run typecheck --workspace @codenomad/ui: pass.NativeTitlebarat 1x and 2x in dark and light themes: mark 24×45.5 px at y=6 in the 36 px bar,alt="CodeNomad", Preferences title unchanged.