Preserve failure nf status set by recordFinalError in buildZuulHttpResponse#2131
Open
lindseyreynolds wants to merge 1 commit into
Open
Preserve failure nf status set by recordFinalError in buildZuulHttpResponse#2131lindseyreynolds wants to merge 1 commit into
lindseyreynolds wants to merge 1 commit into
Conversation
When origin.recordFinalError() sets a specific failure StatusCategory (e.g. from a subclass override), the subsequent unconditional setStatusCategory call was overwriting it with the generic status derived from the response code. Switch to storeStatusCategoryIfNotAlreadyFailure so that a failure status set by recordFinalError is never clobbered. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lindseyreynolds
requested review from
AlexanderEllis,
argha-c,
fool1280,
gavinbunney,
ilanachalom,
jguerra and
tappenzeller
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When origin.recordFinalError() sets a specific failure StatusCategory (e.g. from an origin subclass override), the subsequent unconditional setStatusCategory call was overwriting it with the generic status derived from the response code.
This PR switches to use storeStatusCategoryIfNotAlreadyFailure so that a failure status set by recordFinalError is never overwritten.