Spelling by jsoref · Pull Request #2041 · Netflix/Hystrix

jsoref · 2023-05-21T20:10:48Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/Hystrix/actions/runs/5039485122#summary-13642774871

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/Hystrix/actions/runs/5039485673#summary-13642775939

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref · 2023-05-21T20:11:41Z

 ### Version 1.5.8 ([Maven Central](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22com.netflix.hystrix%22%20AND%20v%3A%221.5.8%22), [Bintray](https://bintray.com/netflixoss/maven/Hystrix/1.5.8/)) ###

-* [Pull 1419](https://github.com/Netflix/Hystrix/pull/1419) When user has not opted in to letting core/maximum threadpools diverge, ensure dynamic updates to coreSize apply to both
+* [Pull 1419](https://github.com/Netflix/Hystrix/pull/1419) When user has not opted into letting core/maximum threadpools diverge, ensure dynamic updates to coreSize apply to both


in to -> into changes have been quite controversial.

Happy to drop this.

Some projects don't like changing changelogs...

jsoref · 2023-05-21T20:11:51Z

 * [Pull 1382](https://github.com/Netflix/Hystrix/pull/1382) Bump jmh to 1.15.  Thanks @monkey-mas!
 * [Pull 1380](https://github.com/Netflix/Hystrix/pull/1380) Add jmh test for open-circuit case
-* [Pull 1376](https://github.com/Netflix/Hystrix/pull/1376) Clean up documentation around thread keep-alive.  Thanks @bitb !
+* [Pull 1376](https://github.com/Netflix/Hystrix/pull/1376) Clean up documentation around thread keep-alive.  Thanks @bltb !


notably, the credit here was wrong...

jsoref · 2023-05-21T20:12:03Z

 ### Version 1.3.11 ([Maven Central](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22com.netflix.hystrix%22%20AND%20v%3A%221.3.11%22)) ###

-* We'll ignore this release ever happened. Exact same binary as 1.3.10. (It helps to push code to Github before releasing.)
+* We'll ignore this release ever happened. Exact same binary as 1.3.10. (It helps to push code to GitHub before releasing.)


jsoref · 2023-05-21T20:13:19Z

     * @throws ClassNotFoundException
     */
-    public Method unbride(final Method bridgeMethod, Class<?> aClass) throws IOException, NoSuchMethodException, ClassNotFoundException {
+    public Method unbridge(final Method bridgeMethod, Class<?> aClass) throws IOException, NoSuchMethodException, ClassNotFoundException {


notable. API break?

jsoref · 2023-05-21T20:13:39Z

        assertEquals(5L, servoPublisher.getRollingMonitor("timeout", HystrixEventType.TIMEOUT).getValue());
        assertEquals(1L, servoPublisher.getRollingMonitor("failure", HystrixEventType.FAILURE).getValue());
-        assertEquals(6L, servoPublisher.getRollingMonitor("falback_success", HystrixEventType.FALLBACK_SUCCESS).getValue());
+        assertEquals(6L, servoPublisher.getRollingMonitor("fallback_success", HystrixEventType.FALLBACK_SUCCESS).getValue());


potentially problematic

ThinkingMan007 · 2023-06-22T14:12:47Z

好的，我已收到。

CloneOfAlex

Nicely Done

ThinkingMan007 · 2024-04-09T22:56:22Z

好的，我已收到。

jsoref added 30 commits May 21, 2023 14:53

spelling: archaius

b5168ba

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: async

37758be

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: atask

5bf2490

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: bltb

a6051ac

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: circuit

ed14a77

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: collapsers

1cee4f3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: command

187bdcb

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: concurrency

c330fcb

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: conveniently

28778ee

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: doing

fa3f6c2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: dynamically

c3ecfc0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: eligible

361e3c0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: execute

83b89ae

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: execution

32e46bc

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: fallback

30d4733

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: github

661ad4a

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: hesitate

8e921f8

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: hystrix

fd206a0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: increment

b030368

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: initialization

c6b934d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: interface

34deb88

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: into

e7700a5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: isn't

c705b94

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: leaks

1cc6bc4

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: milliseconds

a01f14a

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: name

3312d8c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: netflix

80c8d08

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: observable

34ad2b5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: oops

8bcafc8

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: perspective

dcfe438

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 9 commits May 21, 2023 15:56

spelling: request

f5397f9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: semaphore

0efdd0b

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: synchronously

1debe49

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: the

e436516

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: their

59ccdc5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: through

280d6e4

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: transitive

17899fe

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: unbridge

1c6985a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: version

690809d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref commented May 21, 2023

View reviewed changes

CloneOfAlex approved these changes Apr 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling#2041

Spelling#2041
jsoref wants to merge 39 commits into
Netflix:masterfrom
jsoref:spelling

jsoref commented May 21, 2023

Uh oh!

jsoref May 21, 2023

Uh oh!

jsoref May 21, 2023

Uh oh!

jsoref May 21, 2023

Uh oh!

jsoref May 21, 2023

Uh oh!

jsoref May 21, 2023

Uh oh!

ThinkingMan007 commented Jun 22, 2023 via email

Uh oh!

CloneOfAlex left a comment

Uh oh!

ThinkingMan007 commented Apr 9, 2024 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jsoref commented May 21, 2023

Uh oh!

jsoref May 21, 2023

Choose a reason for hiding this comment

Uh oh!

jsoref May 21, 2023

Choose a reason for hiding this comment

Uh oh!

jsoref May 21, 2023

Choose a reason for hiding this comment

Uh oh!

jsoref May 21, 2023

Choose a reason for hiding this comment

Uh oh!

jsoref May 21, 2023

Choose a reason for hiding this comment

Uh oh!

ThinkingMan007 commented Jun 22, 2023 via email

Uh oh!

CloneOfAlex left a comment

Choose a reason for hiding this comment

Uh oh!

ThinkingMan007 commented Apr 9, 2024 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants