Skip to content

Fixed a potential WebSocketException crash that would print to console without getting logged by the logger first. #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AraHaan wants to merge 2 commits into
base: alpha
Choose a base branch
from
Open

Fixed a potential WebSocketException crash that would print to console without getting logged by the logger first. #338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b678005
This fixes a potential WebSocketException crash that would print to c…
AraHaan Apr 30, 2026
f971280
Rethrow the exception after writing it to the log.
AraHaan May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions NetCord/Gateway/GatewayClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using NetCord.Gateway.WebSockets;
using NetCord.Logging;

using WebSocketException = System.Net.WebSockets.WebSocketException;
using WebSocketCloseStatus = System.Net.WebSockets.WebSocketCloseStatus;

namespace NetCord.Gateway;
Expand Down Expand Up @@ -916,8 +917,19 @@ private ValueTask SendIdentifyAsync(ConnectionState connectionState, PresencePro
/// <returns></returns>
public async ValueTask StartAsync(PresenceProperties? presence = null, CancellationToken cancellationToken = default)
{
var connectionState = await StartAsync(new State(), cancellationToken).ConfigureAwait(false);
await SendIdentifyAsync(connectionState, presence, cancellationToken).ConfigureAwait(false);
try
{
var connectionState = await StartAsync(new State(), cancellationToken).ConfigureAwait(false);
await SendIdentifyAsync(connectionState, presence, cancellationToken).ConfigureAwait(false);
}
catch (WebSocketException ex)
{
Log<object?>(LogLevel.Error, null, ex, static (s, e) =>
{
return $"An error occurred while starting the gateway client.{Environment.NewLine}{e}";
});
throw;
}
}

/// <summary>
Expand All @@ -929,8 +941,19 @@ public async ValueTask StartAsync(PresenceProperties? presence = null, Cancellat
/// <returns></returns>
public async ValueTask ResumeAsync(string sessionId, int sequenceNumber, CancellationToken cancellationToken = default)
{
var connectionState = await StartAsync(new State(), cancellationToken).ConfigureAwait(false);
await TryResumeAsync(connectionState, SessionId = sessionId, SequenceNumber = sequenceNumber, cancellationToken).ConfigureAwait(false);
try
{
var connectionState = await StartAsync(new State(), cancellationToken).ConfigureAwait(false);
await TryResumeAsync(connectionState, SessionId = sessionId, SequenceNumber = sequenceNumber, cancellationToken).ConfigureAwait(false);
}
catch (WebSocketException ex)
{
Log<object?>(LogLevel.Error, null, ex, static (s, e) =>
{
return $"An error occurred while resuming.{Environment.NewLine}{e}";
});
throw;
}
}

private protected override bool Reconnect(WebSocketCloseStatus? status, string? description)
Expand Down