Integrate ScannerBuilder into index lookups#3563
Open
apmoriarty wants to merge 2 commits into
Open
Conversation
apmoriarty
force-pushed
the
task/integrate-scanner-builder
branch
from
f2fc2a9 to
0c2cfe9
Compare
SethSmucker
added a commit
that referenced
this pull request
May 21, 2026
PR #3560 removed deprecated eventPerDayThreshold and shardsPerDayThreshold placeholders from the starter source and from docker/config/application-query.yml, but the released spring-boot-starter-datawave-query-1.0.10.jar still embeds the old QueryLogicFactory.xml that references those placeholders. With no fresh 1.0.11 release cut yet, every consumer of the 1.0.10 jar (query, executor, mapreduce-query, cached-results) fails Spring init at startup with: Caused by: java.lang.IllegalArgumentException: Could not resolve placeholder 'datawave.query.logic.logics.BaseEventQuery.eventPerDayThreshold' This blocks the compose-tests workflow on every recent PR opened against integration (#3559, #3562, #3563, #3565 all show the same FAILURE). Bump <version.datawave.starter-query> from 1.0.10 to 1.0.11-SNAPSHOT in the six consuming poms so the multi-module reactor builds the starter from current source (which has #3560's removal) and the query/executor docker images embed the fresh jar. This is a stop-gap. The proper fix is running microservice-cascade-release.yml starting from microservices/starters/query to publish a real 1.0.11; once that lands, these SNAPSHOT pins should be replaced with the released version.
avgAGB
approved these changes
May 26, 2026
Add ExecutionHintHelper to bridge the map of hints in the query logic to scanner specific configs ScanBuilder is now opinionated about setting null execution hints and consistency levels and will throw an IllegalArgumentException AsynIndexLookup now tracks ScanBuilder as a protected variable so unit tests can verify execution hints and consistency levels AsynIndexLookup tests now validate execution hints and consistency level Fix bug where new index lookups were not setting the correct execution hints
apmoriarty
force-pushed
the
task/integrate-scanner-builder
branch
from
0c2cfe9 to
9c52c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ExecutionHintHelper to bridge the map of hints in the query logic to scanner specific configs
ScanBuilder is now opinionated about setting null execution hints and consistency levels and will throw an IllegalArgumentException
AsynIndexLookup now tracks ScanBuilder as a protected variable so unit tests can verify execution hints and consistency levels
AsynIndexLookup tests now validate execution hints and consistency level
Fix bug where new index lookups were not setting the correct execution hints