Skip to content

Fixed matchesInGroupLeft to be consistent with documentation and matchesInGroup (#3514)#3515

Open
FineAndDandy wants to merge 5 commits into
integrationfrom
bugfix/3514
Open

Fixed matchesInGroupLeft to be consistent with documentation and matchesInGroup (#3514)#3515
FineAndDandy wants to merge 5 commits into
integrationfrom
bugfix/3514

Conversation

@FineAndDandy
Copy link
Copy Markdown
Collaborator

depends on #3513 for base test expansion exposing inconsistencies

drewfarris
drewfarris previously approved these changes Apr 16, 2026
avgAGB
avgAGB previously approved these changes Apr 23, 2026
drewfarris
drewfarris previously approved these changes May 19, 2026
@hlgp
Copy link
Copy Markdown
Collaborator

hlgp commented May 27, 2026

Looks good! Much more intuitive. Can we update the description here
https://github.com/NationalSecurityAgency/datawave/blob/integration/warehouse/query-core/src/main/java/datawave/query/language/functions/jexl/MatchesInGroupLeft.java#L19
to align with the changes in the new approach?

@hlgp
Copy link
Copy Markdown
Collaborator

hlgp commented May 27, 2026

One other thing to consider might be to add a -1 option to indicate "I don't know or care how many generations there are, I want them ALL to match" or make 0 = everything, 1 = first group from left, 2 = second group from left, etc.

@FineAndDandy
Copy link
Copy Markdown
Collaborator Author

Looks good! Much more intuitive. Can we update the description here https://github.com/NationalSecurityAgency/datawave/blob/integration/warehouse/query-core/src/main/java/datawave/query/language/functions/jexl/MatchesInGroupLeft.java#L19 to align with the changes in the new approach?

Yep. Good catch

@FineAndDandy
Copy link
Copy Markdown
Collaborator Author

One other thing to consider might be to add a -1 option to indicate "I don't know or care how many generations there are, I want them ALL to match" or make 0 = everything, 1 = first group from left, 2 = second group from left, etc.

so that we don't change existing behavior of 0/default I'd prefer -1 for all. I think its reasonable to add this for both #MATCHES_IN_GROUP and #MATCHES_IN_GROUP_LEFT

@FineAndDandy FineAndDandy dismissed stale reviews from drewfarris and avgAGB via 8b51bbf May 29, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants