Repository navigation
inbox: a refused merge says why, and stays on screen - #6
Merged
Merged
Conversation
Merging pip-web#186 from the portal showed "merging…" and then nothing: the button came back and the PR stayed open. GitHub had refused it because the required `gate` check was still running, and the portal's error handler cleared the status line in the same call that wrote the error, so the refusal was never seen. - The status line is cleared before the error is written, not after. - A refused merge reads the PR's checks and says which are running or failed, or that the branch rules want something else, instead of gh's "the base branch policy prohibits the merge" and its flag advice.
Deploying roster with
|
| Latest commit: |
365a8c9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0613af1.roster-7ih.pages.dev |
| Branch Preview URL: | https://merge-says-why.roster-7ih.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Merging playpip/pip-web#186 from the portal showed "merging…", then the button came back and the PR stayed open. No error appeared.
GitHub refused the merge because the required
gatecheck was still running. The refusal did reach the page, butfailed()inviews/inbox.jswrote the error and then calledbusy(false), which cleared the status line, so the message never showed.failed()now clears the status line before writing the error.gh pr mergenow reads the PR's merge state and checks, and says why in plain words:--auto/--adminadvice.Type of change
fixbug fixTesting
Automated:
test/act.test.tscovers the four messages, using gh's real output for a blocked PR. A new portal test checks that a refused merge leaves its reason on screen with the button enabled again. I put the oldfailed()back and confirmed that test fails.Manual: pip-web#186 is
BLOCKED, with required checkgatein progress, which matches the first message.Checklist
pnpm test:allpasses (533)templates/Breaking changes
None. The portal ships with the CLI, so this reaches tenants with the npm release, not through
roster upgrade.🤖 Generated with Claude Code