Upgrade tests to use FakeItEasy 3.3.2

[blairconrad]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following the Nancy code style guidelines
• I have provided test coverage for my change (where applicable)

Description

3.0.0's non-virtual setup analyzer gives a false positive when complex
argument constraint used in indexer, and this was throwing warnings
in the build
(https://ci.appveyor.com/project/NancyFx/nancy/build/2.0.0-ci0001857-qqrrqvtr#L1311).

[thecodejunkie]

Hi @blairconrad we just pulled in #2720 which put us on the new csproj format. Upgrading FakeItEasy now is just a question of updating these two lines https://github.com/NancyFx/Nancy/blob/master/test/Directory.Build.props#L29-L30 and it will affect all *.Tests projects. Care to send a new PR?

[blairconrad]

Oh, that went through. Cool. I'm happy to resend, but traveling until Monday. If you can wait, I will do by then. If not, I'm not offended if you just close this PR and fix on your own.

…

On Jun 2, 2017 09:21, "Andreas Håkansson" ***@***.***> wrote: Hi @blairconrad <https://github.com/blairconrad> we just pulled in #2720 <#2720> which put us on the new csproj format. Upgrading FakeItEasy now is just a question of updating these two lines https://github.com/NancyFx/Nancy/blob/master/test/ Directory.Build.props#L29-L30 and it will affect all *.Tests projects. Care to send a new PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2742 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADH8FaWk3q9-G2rGgdgP0FqvE19Sn8Dkks5r__47gaJpZM4NRxlY> .