Skip to content

cicd: enable -Wall -Wextra -Werror for clang #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romintomasetti wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

cicd: enable -Wall -Wextra -Werror for clang #1970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__read_env.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ namespace STDEXEC
}

_Receiver __rcvr_;
__optional<_Ty> __result_;
__optional<_Ty> __result_ = __nullopt;
};

template <class _Receiver, class _Query, class _Ty>
Expand Down
9 changes: 9 additions & 0 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@
# limitations under the License.
#=============================================================================

function(add_compile_diagnostics TARGET)
if(CMAKE_CXX_COMPILER_ID STREQUAL Clang OR CMAKE_CXX_COMPILER_ID STREQUAL GNU)
target_compile_options(${TARGET} PRIVATE -Wall -Wextra -Wpedantic -Werror)
endif()
endfunction()

set(stdexec_test_sources
test_main.cpp
stdexec/cpos/test_cpo_bulk.cpp
Expand Down Expand Up @@ -97,6 +103,7 @@ target_link_libraries(common_test_settings INTERFACE $<TARGET_NAME_IF_EXISTS:TBB
# $<$<NOT:$<AND:$<CXX_COMPILER_ID:NVHPC>,$<COMPILE_LANGUAGE:CXX>>>:STDEXEC_ENABLE_EXTRA_TYPE_CHECKING>)

add_executable(test.stdexec ${stdexec_test_sources})
add_compile_diagnostics(test.stdexec)
target_link_libraries(test.stdexec
PUBLIC
STDEXEC::stdexec
Expand All @@ -109,6 +116,7 @@ if(STDEXEC_BUILD_PARALLEL_SCHEDULER)
add_executable(test.parallel_scheduler_replacement
test_main.cpp
stdexec/schedulers/test_parallel_scheduler_replacement.cpp)
add_compile_diagnostics(test.parallel_scheduler_replacement)
target_link_libraries(test.parallel_scheduler_replacement
PUBLIC
STDEXEC::stdexec
Expand All @@ -120,6 +128,7 @@ if(STDEXEC_BUILD_PARALLEL_SCHEDULER)
endif()

add_executable(test.scratch test_main.cpp test_scratch.cpp)
add_compile_diagnostics(test.scratch)
target_link_libraries(test.scratch
PUBLIC
STDEXEC::stdexec
Expand Down
1 change: 1 addition & 0 deletions test/exec/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ set_source_files_properties(test_any_sender.cpp
COMPILE_FLAGS $<$<CXX_COMPILER_ID:MSVC>:/bigobj>)

add_executable(test.exec ${exec_test_sources})
add_compile_diagnostics(test.exec)
target_link_libraries(test.exec
PUBLIC
STDEXEC::stdexec
Expand Down
2 changes: 1 addition & 1 deletion test/test_common/scope_helpers.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ namespace
-> ex::completion_signatures_of_t<ex::__child_of<std::remove_cvref_t<Sender>>, Env...>
{
return {};
};
}
};

struct counting_resource : std::pmr::memory_resource
Expand Down