Repository navigation
Check sectioned unverified-payload inspection output - #89
Merged
Merged
Conversation
Assert separate format/signature rows and deployment-scoped capacities in plain payload inspection. Check graph counts and displayed durations, exact allocation/reservation sizes, buffers and initializer payloads for every rank. Production rendering and package/signature validation are unchanged. Validation: all 7 unverified_payload integration tests pass on Linux with CUDA hidden; rustfmt and staged diff checks pass. Windows was not run. Design-Signed-Off-By: Codex (GPT-6 Sol); design-review=babb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unverified payload inspection prints separate Format/Signatures rows, deployment capacity sections and per-rank graph/memory sections. Two CLI integration tests expect combined lines and raw units, so the native Linux job fails despite valid output. Assert the supported sectioned layout while retaining explicit unverified status, deployment ownership, graph counts/duration, allocation and reservation sizes, buffer bindings and initializer payload/offset/size checks. Production rendering and signature/package validation are unchanged.
Implemented as a test-only change from main 3267c05. The baseline Linux job reproduces the same failures as the independent FlashInfer-pin PR: https://github.com/NVIDIA/flare-local-inference/actions/runs/40243066916/job/121318818911. Assertions check every fixture deployment/rank; JSON's exact nanosecond metadata coverage remains intact while plain output checks the displayed microsecond value.
Reproducer and validation:
cargo test --locked --release --manifest-path flare/Cargo.toml --test unverified_payloadQualified on Linux with Rust/Cargo 1.95 and CUDA hidden: 7 passed, 0 failed. rustfmt and staged diff/design review pass. Windows remains unrun locally. This is CI test compatibility, with no performance claim.