Repository navigation
Preserve the source license when signing a payload package - #84
Closed
original-el8 wants to merge 1 commit into
Closed
original-el8 wants to merge 1 commit into
original-el8 wants to merge 1 commit into
Conversation
Signing replaces the publisher identity, and promotion copied the target's empty license fields over the source package's recorded license. The resulting package loaded without a license disclosure. Carry the source license name and link unless the target publisher supplies one. Promotion metadata changes only; payloads, executable bytes, and execution contracts are unchanged. Validation: 4 conversion promotion tests; 22 native publication and production signing tests. Fixes #81 Reported by @mark-yong in #81. Design-Signed-Off-By: ds41; design-review=babb
original-el8
force-pushed
the
fix/81-sign-license
branch
from
October 26, 2026 12:02
2da5c21 to
34cbdb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81. Reported by @mark-yong.
ignition signreplaced the publisher identity and copied the target's empty license fields over the source package's recorded license, so promoted packages loaded without a license disclosure.Promotion now keeps the source package's
license_nameandlicense_linkunless the target publisher supplies its own. Payloads, executable bytes, and execution contracts are unchanged.Validation:
cargo test --locked --manifest-path helios/Cargo.toml --features runtime-package,server --lib package::conversion::tests— 43 passed..venv/bin/python -m pytest tests/preparation/test_native_publication.py tests/cli/test_production_signing.py -q— 22 passed.flare-heliopausefrom the branch before the Python run.