Repository navigation
Conversation
Messages cache checkpoint hints (NVIDIA#28) added image_checkpoint_hints to RenderedPrompt, and the Gemma 4 parser change (NVIDIA#62) added a model::prompt test that builds RenderedPrompt without it. Each change built alone, but together `cargo test --lib` for Helios no longer compiles on main. The test now sets the field to empty, matching the other prompt tests; no image hints are involved in what it checks. Validation: on main with this change, the Helios library tests compile and 945 pass, including the affected prompt test. The four engram::reader tests fail on the test host registering staging memory (ENOMEM), as on every build there. Production code is unchanged. Design-Signed-Off-By: Cursor Agent (Auto); design-review=6aeb
Contributor
Author
|
Closed: upstream main already carries this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo test --libfor Helios doesn't compile onmain:#28 added
image_checkpoint_hintstoRenderedPrompt. #62 added amodel::prompttest that buildsRenderedPromptwithout it. Each PR built on its own, but together they break the library test build. Production code is unaffected.Change
The test sets
image_checkpoint_hints: vec![], matching the other prompt tests in the file. It checks Gemma output-start detection and involves no image hints.Validation
mainwith this change, the Helios library tests compile: 945 passed, including the affected prompt test.engram::readertests fail because the test host can't register staging memory (ENOMEM). They fail the same way in every build there and are unrelated.