Repository navigation
Fix GLM tool-call argument tag parsing - #59
aarongiuffre wants to merge 2 commits into
Conversation
|
This PR and #179 need a shared tool-argument semantics decision. This diff adds array coercion (including comma splitting and wrapping strings in arrays) and richer parse errors. #179 deliberately retains generated off-schema values without coercion, with streaming coverage for #39. They are overlapping proposals, not interchangeable fixes. Marked |
|
Marked This PR also adds comma-splitting/string-to-array coercion and diagnostics, which are different semantics from retaining the generated value. Re-establish a failing input on main before carrying those changes forward; a successful controlled tool call alone does not show that they remain necessary. Close the proposal if its target failure is resolved, or narrow it to the remaining demonstrated defect. @aarongiuffre GitHub reports merge conflicts with
Please reconcile the branch with main and rerun the checks affected by the resolution. |
Summary
Fix GLM tool-call argument parsing that could fail with: GLM tool call requires an argument key.
Validation
Testing notes
The controlled tool-call test passed. Additional regression coverage for other argument encodings and streaming responses would be useful.