Repository navigation
Add requested generation logprob token IDs - #35
Merged
Merged
Conversation
Gather up to 128 IDs through raw-logprob reporting and copy the requested frame width. Preserve older package layouts and prompt-scoring validation. CPU: release build, qualification check and extension install passed. Helios 893 passed, 4 Engram ENOMEM failures, 22 ignored; integration 31 passed, 12 ignored; Flare 134 passed, 1 ignored; protocols 47 passed; Python 10 passed, 1 skipped. CLI clippy passed; Helios has 3 existing range errors; full formatting has existing differences. GPU and service checks remain for the test round. Design-Signed-Off-By: yatesdr; design-review=6aeb
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #26 (the scoring primitive; the decision routes follow in separate PRs).
Problem
Decision and distillation clients need the logprob of specific tokens at each generated position: label tokens for classification, or a teacher's top set for KLD. Today Flare returns only the natural top 20, so a label outside it has no value at all.
Change
logprob_token_ids: [id, ...]on Chat, Completions and Responses, matching vLLM's field:Tests
Helios 893, integration 31, protocol 47 and Flare 134 pass on CPU, plus the Python component tests. An earlier revision passed CUDA, TP2/TP4 replay and 148 live API checks on Qwen3.8, with requested values within 9.0e-7 of an FP64 reference. DeepSeek V4.1 and this revision's GPU runs are still to do.