Skip to content

add workflow to label issues as stale#695

Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
rahulait:add-stale-workflow
Mar 4, 2026
Merged

add workflow to label issues as stale#695
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
rahulait:add-stale-workflow

Conversation

@rahulait
Copy link
Copy Markdown
Contributor

@rahulait rahulait commented Mar 3, 2026

Description

This PR adds the workflow which runs periodically and labels issues as stale if there is no activity for a certain period.

Motivation

To keep all our repos in sync on how we handle issues, we are adding this worklow to this repo as well.

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • 🔧 Refactoring (no functional changes)
  • 🧪 Test improvements
  • 🔨 Build/CI changes

Changes Made

Testing

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing performed

Test Commands Run

# Commands used to test the changes
make test
make lint

Checklist

  • My code follows the project's coding conventions
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have updated the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • New and existing tests pass locally
  • I have signed off my commits (git commit -s)

Additional Notes

Copilot AI review requested due to automatic review settings March 3, 2026 17:17
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a scheduled GitHub Actions workflow to automatically mark inactive issues as stale and eventually close them, helping keep issue hygiene consistent across repositories.

Changes:

  • Introduces a new scheduled workflow (stale.yaml) using actions/stale@v10.
  • Configures stale/close timings and messages for inactive issues.
  • Defines job-level permissions for the stale automation.

jobs:
stale:
permissions:
actions: write
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job requests actions: write, but actions/stale only needs to read/update issues (and optionally pull requests). Granting actions: write is broader than necessary; please remove it to follow least-privilege permissions.

Suggested change
actions: write

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional as its required to clean stale cache. See actions/stale#1248

Comment on lines +10 to +20
permissions:
actions: write
issues: write
runs-on: ubuntu-latest

steps:
- uses: actions/stale@v10
with:
stale-issue-message: 'This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.'
stale-issue-label: 'lifecycle/stale'
exempt-issue-labels: 'lifecycle/frozen,feature,enhancement'
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/stale processes pull requests by default. This workflow only grants issues: write, so runs may fail when the action tries to label/close PRs. If the intent is issues-only, set only-issues: true (or disable PR handling); otherwise add pull-requests: write permission and configure the PR-specific settings/messages.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@rahulait rahulait Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect suggestion. There is no only-issues: true option and this workflow is not touching PRs, its only labeling/closing issues here as configured. See https://github.com/actions/stale?tab=readme-ov-file#all-options

If someone wants to label PRs as well in future, those permissions should be set then.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 22634518209

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.275%

Totals Coverage Status
Change from base Build 22623448927: 0.0%
Covered Lines: 2617
Relevant Lines: 5421

💛 - Coveralls

Copy link
Copy Markdown
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please address copilot comments before we can move on

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@rahulait
Copy link
Copy Markdown
Contributor Author

rahulait commented Mar 3, 2026

Thanks for the PR, please address copilot comments before we can move on

I've addressed all the issues reported by copilot. PTAL

Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ArangoGutierrez ArangoGutierrez merged commit 85d1356 into NVIDIA:main Mar 4, 2026
53 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants