FIX Remove spurious IsolationForest arguments - #8486
Conversation
These arguments should not have been added, now they are gone.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughIsolationForest no longer exposes ChangesIsolationForest interface cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR removes unsupported IsolationForest arguments and updates the related tests; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jcrist
left a comment
There was a problem hiding this comment.
Thanks! I've moved this to a breaking change just to note the arg removal (though I doubt anyone is relying on unsupported args from a just released estimator).
One small comment, do with it what you will.
This should be tested in cuml.accel
|
Thanks for the breaking label, it is the smarter choice. |
|
/merge |
These arguments should not have been added, now they are gone. This removes the
warm_startconstructor argument that was unsupported and only ever raised. The same goes for thesample_weightsargument used infit()and friends.No deprecation cycles because this fixes a bug (arguments should never have been there in the first place).
Towards #8420