Fix conditional outer join root predicates [databricks] - #16109
Merged
Merged
Conversation
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Contributor
|
Collaborator
Author
|
build |
1 similar comment
Collaborator
Author
|
build |
Collaborator
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16067.
Description
Conditional right outer joins can fail with
The expression must produce a boolean output, while conditional full outer joins can return incorrect results when the remaining condition is a rootGpuBoundReference.For
BuildLeft,LazyCompiledConditionreorders the AST inputs but previously remapped only child expressions, leaving a root reference bound to the wrong column. This change remaps the root reference before recursively transforming its children.CPU/GPU regression tests cover right and full outer joins with the
AUTO,HASH_ONLY, andINNER_SORT_WITH_POSTstrategies.Performance testing is not required because this changes only one-time AST condition rebinding and adds no row or batch hot-path work.
AI assistance disclosure: Codex assisted with issue implementation and validation. It was reviewed by the author before publication.
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance