libcu++: respect atomic scopes in pointer arithmetic operations. - #10809
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughPointer atomic ChangesPointer atomic scope handling
Assessment against linked issues
Possibly related PRs
Suggested reviewers: Mergeability Score: ⚪ Minimal · up to The PR updates atomic pointer arithmetic to honor the intended atomic scope; the remaining test-only const-correctness cleanup does not affect runtime behavior. No actionable merge-blocking risk remains after normal checks. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: bf464693-4e73-4a77-8eb8-dbc4b288cf2a
📒 Files selected for processing (3)
libcudacxx/include/cuda/std/__atomic/api/common.hlibcudacxx/test/atomic_codegen/atomic_add_non_volatile.culibcudacxx/test/atomic_codegen/atomic_sub_non_volatile.cu
⏱️ CCCL compile-time benchmark comparison: Public headers compile-time benchResult: 0 regression row(s), 1 improvement row(s) above threshold.
Artifacts: reports and traces Direct file processing
🟢 Direct file processing — Improvements
|
🥳 CI Workflow Results🟩 Finished in 2h 02m: Pass: 100%/117 | Total: 2d 18h | Max: 1h 29m | Hits: 59%/636436See results here. |
Description
It seems that we've had pointer arithmetic go through the system scope. This PR fixes that.
Resolves #10808.
Checklist