Skip to content

Fix E721 type comparisons#2003

Merged
crcrpar merged 1 commit into
NVIDIA:masterfrom
LeSingh1:fix-ruff-e721-type-comparisons
May 18, 2026
Merged

Fix E721 type comparisons#2003
crcrpar merged 1 commit into
NVIDIA:masterfrom
LeSingh1:fix-ruff-e721-type-comparisons

Conversation

@LeSingh1
Copy link
Copy Markdown
Contributor

@LeSingh1 LeSingh1 commented May 15, 2026

This fixes one ignored Ruff rule from #1964.

Changes:

  • Replaces direct type comparisons with isinstance or not isinstance.
  • Removes E721 from the Ruff ignore list.
  • Leaves all other ignored Ruff rules untouched.

Validation:

python -m ruff check . --select E721
python -m ruff check .

Both pass.

crcrpar
crcrpar approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@crcrpar crcrpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@crcrpar crcrpar merged commit 33254f2 into NVIDIA:master May 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crcrpar crcrpar crcrpar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LeSingh1 @crcrpar