Skip to content
Open
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
b1574f0
produce/consume extra output
vthumbe1503 Jul 28, 2026
63192ab
allow for fusions with producer/consumer being part of same fuser wit…
vthumbe1503 Aug 4, 2026
3b4b523
cleanup
vthumbe1503 Aug 4, 2026
de38ed8
minor cleanup
vthumbe1503 Aug 4, 2026
385b0d5
dispatch combine impl
vthumbe1503 Aug 4, 2026
ad3b044
fusible ops test
vthumbe1503 Aug 5, 2026
5fb0d3a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 5, 2026
2ba4f6a
Merge remote-tracking branch 'nvidia_origin/main' into enable_extra_o…
vthumbe1503 Aug 5, 2026
3af2ecc
keep just ops infra changes
vthumbe1503 Aug 5, 2026
d7d6380
cleanup with residual tests
vthumbe1503 Aug 5, 2026
74f563a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 5, 2026
29d23f2
Merge branch 'main' into enable_extra_out_consumption
vthumbe1503 Aug 6, 2026
87e2b36
address review comment
vthumbe1503 Aug 6, 2026
80601dc
update to cleaner documentation
vthumbe1503 Aug 7, 2026
5070e34
address review comments
vthumbe1503 Aug 7, 2026
ae41ad3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 7, 2026
f82cbed
some cleanup
vthumbe1503 Aug 9, 2026
5a4e1ec
update docs
vthumbe1503 Aug 9, 2026
0a479c7
pin channels through channel version
vthumbe1503 Aug 9, 2026
d679998
unecessary handling removal
vthumbe1503 Aug 9, 2026
8f7ba95
simplify
vthumbe1503 Aug 9, 2026
c62bb15
doc update + extra_grad = None case
vthumbe1503 Aug 9, 2026
a93b820
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 9, 2026
35b73b1
test cleanup
vthumbe1503 Aug 9, 2026
6801a6d
no need to check staleness in every forward call
vthumbe1503 Aug 9, 2026
6688e8a
remove redundant tests
vthumbe1503 Aug 9, 2026
12430c2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 9, 2026
b189550
revert from bad names
vthumbe1503 Aug 9, 2026
a4cc112
keep simple
vthumbe1503 Aug 9, 2026
7edaf89
Merge branch 'enable_extra_out_consumption' of github.com:vthumbe1503…
vthumbe1503 Aug 9, 2026
5ba6055
unecessary checks
vthumbe1503 Aug 9, 2026
76826dc
minor doc
vthumbe1503 Aug 9, 2026
827f8e9
Merge branch 'main' into enable_extra_out_consumption
vthumbe1503 Aug 10, 2026
63a4ea3
fix lint
vthumbe1503 Aug 10, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 143 additions & 14 deletions docs/examples/op_fuser/op_fuser.rst
Original file line number Diff line number Diff line change
Expand Up @@ -113,43 +113,172 @@ quantized compute.
Branching operations
^^^^^^^^^^^^^^^^^^^^

The operation fuser supports very limited branching behavior. While
the operations must be in sequential order, some operations can accept
The operation fuser supports limited branching behavior. While the
operations must be in sequential order, some operations can accept
extra inputs or produce extra outputs. For example, ``AddExtraInput``
will add an extra input tensor to the intermediate tensor and
``MakeExtraOutput`` will return the intermediate tensor as an extra
output. When calling a ``Sequential`` that contains any of these
branching operations, the extra inputs should be passed in as
arguments and the extra outputs will be returned.
adds an extra input tensor to the intermediate tensor, and
``MakeExtraOutput`` returns the intermediate tensor as an extra output.
When calling a ``Sequential`` that contains any of these branching
operations, the extra inputs should be passed as arguments and the
extra outputs will be returned after the main output.

.. code-block:: python

import torch
import transformer_engine.pytorch as te

# Construct MLP with residual connection
# Construct an MLP with a residual connection.
fc1 = te.ops.Sequential(
te.ops.LayerNorm(4096),
te.ops.MakeExtraOutput(), # Output residual
te.ops.MakeExtraOutput(), # Output the residual.
te.ops.Linear(4096, 28672),
te.ops.SwiGLU(),
)
fc2 = te.ops.Sequential(
te.ops.Linear(14336, 4096),
te.ops.AddExtraInput(), # Add residual
te.ops.AddExtraInput(), # Add the residual.
)

# Forward pass
# Pass the extra output from fc1 as the extra input to fc2.
x = torch.randn(16384, 4096, device="cuda")
y, residual = fc1(x)
y = fc2(y, residual)

.. figure:: ./residual_layernorm_mlp.png
:align: center

Operations for an MLP block with a residual connection. Note that
the block has been split into two sections, each with one branching
operation.
Operations for an MLP block with a residual connection. The block
is split into two sections so that the caller can pass the extra
output from the first section to the second.

Extra tensor channels
"""""""""""""""""""""

Extra inputs and outputs may optionally specify a channel. Assigning
the same channel name to an extra output and one or more later extra
inputs routes the tensor internally within the same
``OperationFuser``. An extra input connected to an earlier producer is
removed from the public ``Sequential`` arguments because the channel
supplies it.
Extra outputs remain in the public ``Sequential`` return value,
including outputs that are also consumed through a channel.
Comment on lines +157 to +164

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you read pendantically, then this technically describes our current behavior where we ignore unmatched input channels. However, this is subtle and non-obvious. Better to error out if the input channel is invalid.

Suggested change
Extra inputs and Extra outputs may optionally specify a channel. Assigning
the same channel name to an extra output and one or more later extra
inputs routes the tensor internally within the same
``OperationFuser``. An extra input connected to an earlier producer is
removed from the public ``Sequential`` arguments because the channel
supplies it.
Extra outputs remain in the public ``Sequential`` return value,
including outputs that are also consumed through a channel.
Branching operations can also route their extra inputs and outputs within the same ``Sequential`` via named channels. Extra output tensors with a specified channel can be consumed by other operations, in addition to being returned from the ``Sequential``. Extra input tensors with a specified channel are accessed internally instead of being provided as arguments to ``Seqential``.


With a channel, the residual block above can be expressed using one
``Sequential``:

.. code-block:: python

import torch
import transformer_engine.pytorch as te

make_residual = te.ops.MakeExtraOutput()
add_residual = te.ops.AddExtraInput()
make_residual.set_extra_output_channel(0, "residual")
add_residual.set_extra_input_channel(0, "residual")

block = te.ops.Sequential(
te.ops.LayerNorm(4096),
make_residual,
te.ops.Linear(4096, 28672),
te.ops.SwiGLU(),
te.ops.Linear(14336, 4096),
add_residual,
)

# The residual is routed internally and is also returned to the caller.
x = torch.randn(16384, 4096, device="cuda")
y, residual = block(x)

Channels are also useful for mixture-of-experts blocks. The following
example assumes custom ``Dispatch`` and ``Combine`` basic operations.
``Dispatch`` has one public extra input containing router probabilities
and three extra outputs: split sizes, token probabilities, and a
routing map. ``Combine`` consumes the routing map.

.. code-block:: python

import transformer_engine.pytorch as te
from my_ops import Dispatch, Combine

num_experts = 8
hidden_size = 4096
ffn_size = 14336

dispatch = Dispatch(num_experts)
fc1 = te.ops.GroupedLinear(
num_experts, hidden_size, 2 * ffn_size, bias=False
)
activation = te.ops.ScaledSwiGLU()
fc2 = te.ops.GroupedLinear(
num_experts, ffn_size, hidden_size, bias=False
)
combine = Combine(num_experts)

# Dispatch extra outputs:
# 0: split sizes, 1: token probabilities, 2: routing map
dispatch.set_extra_output_channel(0, "m_splits")
dispatch.set_extra_output_channel(1, "probs")
dispatch.set_extra_output_channel(2, "routing_map")

fc1.set_extra_input_channel(0, "m_splits")
activation.set_extra_input_channel(0, "probs")
fc2.set_extra_input_channel(0, "m_splits")
combine.set_extra_input_channel(0, "routing_map")

moe = te.ops.Sequential(dispatch, fc1, activation, fc2, combine)

# Dispatch's extra input has no channel, so the caller passes router_probs.
# Channels supply all later extra inputs internally, while Dispatch's
# extra outputs are still returned in their original order.
y, m_splits, probs, routing_map = moe(x, router_probs)

Channels cannot connect operations in different ``OperationFuser``
instances. In particular, an ordinary PyTorch module inside a
``Sequential`` splits the fusible operations on either side into
separate fusers. The following channel connection is therefore not
Comment on lines +235 to +238

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if Sequential could handle channels across OperationFusers, but the implementation would be quite hairy and not worth it for the current effort.

supported:

.. code-block:: python

make_residual = te.ops.MakeExtraOutput()
add_residual = te.ops.AddExtraInput()
make_residual.set_extra_output_channel(0, "residual")
add_residual.set_extra_input_channel(0, "residual")

block = te.ops.Sequential(
make_residual,
torch.nn.Identity(), # Splits the operations into separate fusers.
add_residual,
)

Use the public extra output and extra input interfaces, as in the
two-``Sequential`` example above, when the producer and consumer cannot
be placed in the same ``OperationFuser``.

The following conditions apply to extra tensor channels:

- A producer must appear before all of its consumers. Backward edges
and cycles are not supported.
- An output channel name has at most one producer, but its output may
fan out to multiple consumers.
- A named output does not require a consumer. It is still returned as
a public extra output.
- A channel is scoped to one ``OperationFuser``. In a ``Sequential``,
ordinary PyTorch modules split adjacent fusible operations into
separate fusers, and channels cannot cross that boundary.
- The caller passes extra inputs that are not connected to an earlier
producer in the same fuser. Channel-connected extra input slots do
not appear in the ``Sequential`` arguments.
- The caller receives every extra output in the original basic-operation
and slot order. This includes channel-bound outputs that are also
consumed internally. Gradients supplied for a returned output are
combined with gradients from its internal channel consumers.

Channel-connected basic operations may still be replaced by registered
``FusedOperation`` implementations. If a fused operation contains both
the producer and consumer of a channel, its ``fuser_forward`` and
``fuser_backward`` implementations are responsible for routing the
tensor and its gradient between those basic operations.

Developer guide
---------------
Expand Down
Loading
Loading