test: align Claude and Codex plugin E2E gateways

[willkill07]

Overview

Align the Claude Code and Codex plugin E2E fixtures with the documented persistent Relay gateway lifecycle, current sidecar-reuse behavior, and their test-owned observability output.

• I confirm this contribution is my own work, or I have the right to submit it under this project's license.
• I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

• Run both plugin E2E fixtures against the default persistent gateway port, 127.0.0.1:47632, rather than generating an MCP-only test port.
• Update Codex to expect verified live-sidecar reuse across persistent configuration changes; force reinstall still retires the old sidecar and verifies the rotated provider key.
• Keep ATOF output under each test workspace, ignore Codex's known post-terminal rollout-flush warning, and reliably terminate the Claude process group on timeout.

Where should the reviewer start?

Review scripts/test-claude-plugin-e2e.sh and scripts/test-codex-plugin-e2e.sh, focusing on endpoint setup, sidecar lifecycle, and test-owned ATOF paths.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• Relates to: RELAY-858

Summary by CodeRabbit

• Tests
  • End-to-end testing now uses consistent gateway connections and shared event workspaces for more predictable validation.
  • Plugin address checks verify the configured connection directly.
  • Provider-request checks are less dependent on a specific API key value.
  • Test cleanup now reliably terminates related processes, including forced termination when necessary.
  • Sidecar tests validate reuse after credential rotation and retirement after forced reinstall.
  • Known transient Codex rollout errors are handled during testing.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: e6906006-8e47-4f19-9f53-3d31f1b3cad8

📥 Commits

Reviewing files that changed from the base of the PR and between a0043eb and f9b30af.

📒 Files selected for processing (1)

• scripts/test-codex-plugin-e2e.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (1)

• GitHub Check: Check / Run

🧰 Additional context used

📓 Path-based instructions (1)

Review automation changes for reproducibility, pinned versions where appropriate, secret handling, and consistency with the documented validation matrix.

⚙️ CodeRabbit configuration file

Files:

• scripts/test-codex-plugin-e2e.sh

---

Walkthrough

The Claude and Codex plugin E2E scripts now use gateway port 47632. The scripts update cleanup, event storage, rollout-error handling, and sidecar lifecycle assertions.

Changes

E2E harness updates

Layer / File(s)	Summary
Claude plugin E2E validation scripts/test-claude-plugin-e2e.sh	The script validates 127.0.0.1:47632, terminates Claude process groups with escalation, and removes the fixed provider API-key assertion.
Codex workspace and event output scripts/test-codex-plugin-e2e.sh	The script creates the ATOF workspace, expands variables in plugins.toml, writes events to $work/atof/events.jsonl, and reads assertions from that path.
Codex sidecar lifecycle validation scripts/test-codex-plugin-e2e.sh	The script ignores the known rollout-flush error and validates sidecar reuse after credential rotation. Forced reinstall remains the operation that retires the sidecar and applies rotated credentials.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 82726

The E2E harness updates match the documented gateway and workspace contracts and are mergeable.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title uses valid Conventional Commits syntax with the allowed lowercase type test, an imperative summary, no trailing period, and 48 characters. It accurately describes the E2E gateway alignment…
Description check	✅ Passed	The description includes all required sections, completed contribution and duplication confirmations, concrete change details, reviewer guidance, and the permitted Relates to issue reference.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}